Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates copy for verify modal #4099

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Updates copy for verify modal #4099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .storybook/locale.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ const locale: Record<string, string> = {
walletVerificationNote1: 'Uphold may require you to verify your identity based on services requested.',
walletVerificationNote2: 'Brave Software Inc. does not process, store, or access any of the personal information that you provide to Uphold when you establish an account with them.',
walletVerificationTitle1: 'Ready to verify your wallet?',
walletVerificationTitle2: 'Verification is not necessary to earn rewards for creator contributions',
walletVerified: 'Verified',
welcome: 'Welcome!',
welcomeBack: 'Welcome Back!',
Expand Down
1 change: 0 additions & 1 deletion browser/ui/webui/brave_webui_source.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,6 @@ void CustomizeWebUIHTMLSource(const std::string &name,
{ "walletVerificationNote1", IDS_BRAVE_UI_WALLET_VERIFICATION_NOTE1 },
{ "walletVerificationNote2", IDS_BRAVE_UI_WALLET_VERIFICATION_NOTE2 },
{ "walletVerificationTitle1", IDS_BRAVE_UI_WALLET_VERIFICATION_TITLE1 },
{ "walletVerificationTitle2", IDS_BRAVE_UI_WALLET_VERIFICATION_TITLE2 },
{ "walletVerified", IDS_BRAVE_UI_WALLET_VERIFIED },

{ "walletFailedButton", IDS_BRAVE_UI_WALLET_FAILED_BUTTON },
Expand Down
1 change: 0 additions & 1 deletion components/brave_rewards/resources/extension/brave_rewards/background/api/locale_api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ export const getUIMessages = (): Record<string, string> => {
'walletVerificationListCompact3',
'walletVerificationListHeader',
'walletVerificationTitle1',
'walletVerificationTitle2',
'walletVerified',
'yourBalance'
]
Expand Down
4 changes: 0 additions & 4 deletions components/brave_rewards/resources/ui/components/modalVerify/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
StyledWalletIcon,
StyledHeaderText,
StyledTitle,
StyledSubtitle,
StyledListTitle,
StyledListItem,
StyledListIcon,
Expand Down Expand Up @@ -65,9 +64,6 @@ export default class ModalVerify extends React.PureComponent<Props, {}> {
<StyledTitle level={1}>
{getLocale('walletVerificationTitle1')}
</StyledTitle>
<StyledSubtitle level={2}>
{getLocale('walletVerificationTitle2')}
</StyledSubtitle>
</StyledHeaderText>
</StyledHeader>
</>
Expand Down
15 changes: 4 additions & 11 deletions components/brave_rewards/resources/ui/components/modalVerify/style.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const StyledWalletIcon = styled<{}, 'div'>('div')`
export const StyledHeaderText = styled<{}, 'div'>('div')`
vertical-align: middle;
display: inline-block;
padding-left: 22px;
padding: 3px 0 0 22px;
`

export const StyledTitle = styled(Heading)`
Expand All @@ -54,20 +54,12 @@ export const StyledTitle = styled(Heading)`
font-weight: 600;
`

export const StyledSubtitle = styled(Heading)`
color: ${p => p.theme.palette.white};
font-family: ${p => p.theme.fontFamily.body};
font-size: 14px;
line-height: 24px;
`

export const StyledListTitle = styled(Heading)`
font-weight: 600;
font-size: 17px;
line-height: 25px;
padding: 0 0 0 36px;
padding: 0;
color: ${p => p.theme.palette.white};
margin-bottom: -7px;
`

export const StyledListItem = styled<StyleProps, 'div'>('div')`
Expand Down Expand Up @@ -96,7 +88,7 @@ export const StyledButton = styled(Button as ComponentType<ButtonProps>)`
padding: 11px 40px;
width: auto;
min-height: auto;
margin-top: -20px;
margin-top: -25px;
`

export const StyledFooter = styled<StyleProps, 'div'>('div')`
Expand All @@ -121,6 +113,7 @@ export const StyledContent = styled<{}, 'div'>('div')`
export const StyledLeftSide = styled<{}, 'div'>('div')`
width: 50%;
padding-right: 10px;
margin-top: 9px;
`

export const StyledRightSide = styled<{}, 'div'>('div')`
Expand Down
5 changes: 2 additions & 3 deletions components/resources/brave_components_strings.grd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,9 +632,8 @@
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_LIST1" desc="">Withdraw BAT that you earn from viewing privacy-respecting ads</message>
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_LIST2" desc="">Purchase additional BAT with credit cards and other sources</message>
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_LIST3" desc="">Withdraw BAT that you may have previously added to your Brave Rewards wallet</message>
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_HEADER" desc="">Benefits of verifying</message>
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_TITLE1" desc="">Ready to verify your wallet?</message>
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_TITLE2" desc="">Verification is not necessary to contribute rewards to creators</message>
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_HEADER" desc="">But if you verify, you can...</message>
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_TITLE1" desc="">Verifying your wallet is optional.</message>
<message name="IDS_BRAVE_UI_WALLET_VERIFIED" desc="">Verified</message>
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_NOTE1" desc="">Uphold may require you to verify your identity based on services requested.</message>
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_NOTE2" desc="">Brave Software Inc. does not process, store, or access any of the personal information that you provide to Uphold when you establish an account with them.</message>
Expand Down