From 74652d083bae303fde3f5e5c60aa272960a7ee73 Mon Sep 17 00:00:00 2001 From: NejcZdovc Date: Thu, 28 Nov 2019 09:38:18 +0100 Subject: [PATCH] Updates copy for verify modal Resolves https://github.com/brave/brave-browser/issues/7102 --- .storybook/locale.ts | 1 - browser/ui/webui/brave_webui_source.cc | 1 - .../brave_rewards/background/api/locale_api.ts | 1 - .../resources/ui/components/modalVerify/index.tsx | 4 ---- .../resources/ui/components/modalVerify/style.ts | 15 ++++----------- components/resources/brave_components_strings.grd | 5 ++--- 6 files changed, 6 insertions(+), 21 deletions(-) diff --git a/.storybook/locale.ts b/.storybook/locale.ts index 2aa04ea36026..c582a38b0471 100644 --- a/.storybook/locale.ts +++ b/.storybook/locale.ts @@ -288,7 +288,6 @@ const locale: Record = { walletVerificationNote1: 'Uphold may require you to verify your identity based on services requested.', walletVerificationNote2: 'Brave Software Inc. does not process, store, or access any of the personal information that you provide to Uphold when you establish an account with them.', walletVerificationTitle1: 'Ready to verify your wallet?', - walletVerificationTitle2: 'Verification is not necessary to earn rewards for creator contributions', walletVerified: 'Verified', welcome: 'Welcome!', welcomeBack: 'Welcome Back!', diff --git a/browser/ui/webui/brave_webui_source.cc b/browser/ui/webui/brave_webui_source.cc index 42eaa6163da1..4b991ba0464b 100644 --- a/browser/ui/webui/brave_webui_source.cc +++ b/browser/ui/webui/brave_webui_source.cc @@ -578,7 +578,6 @@ void CustomizeWebUIHTMLSource(const std::string &name, { "walletVerificationNote1", IDS_BRAVE_UI_WALLET_VERIFICATION_NOTE1 }, { "walletVerificationNote2", IDS_BRAVE_UI_WALLET_VERIFICATION_NOTE2 }, { "walletVerificationTitle1", IDS_BRAVE_UI_WALLET_VERIFICATION_TITLE1 }, - { "walletVerificationTitle2", IDS_BRAVE_UI_WALLET_VERIFICATION_TITLE2 }, { "walletVerified", IDS_BRAVE_UI_WALLET_VERIFIED }, { "walletFailedButton", IDS_BRAVE_UI_WALLET_FAILED_BUTTON }, diff --git a/components/brave_rewards/resources/extension/brave_rewards/background/api/locale_api.ts b/components/brave_rewards/resources/extension/brave_rewards/background/api/locale_api.ts index 953803ee6a82..570bc3ba6946 100644 --- a/components/brave_rewards/resources/extension/brave_rewards/background/api/locale_api.ts +++ b/components/brave_rewards/resources/extension/brave_rewards/background/api/locale_api.ts @@ -141,7 +141,6 @@ export const getUIMessages = (): Record => { 'walletVerificationListCompact3', 'walletVerificationListHeader', 'walletVerificationTitle1', - 'walletVerificationTitle2', 'walletVerified', 'yourBalance' ] diff --git a/components/brave_rewards/resources/ui/components/modalVerify/index.tsx b/components/brave_rewards/resources/ui/components/modalVerify/index.tsx index 75b17b2f05f7..7eeb18e055cb 100644 --- a/components/brave_rewards/resources/ui/components/modalVerify/index.tsx +++ b/components/brave_rewards/resources/ui/components/modalVerify/index.tsx @@ -12,7 +12,6 @@ import { StyledWalletIcon, StyledHeaderText, StyledTitle, - StyledSubtitle, StyledListTitle, StyledListItem, StyledListIcon, @@ -65,9 +64,6 @@ export default class ModalVerify extends React.PureComponent { {getLocale('walletVerificationTitle1')} - - {getLocale('walletVerificationTitle2')} - diff --git a/components/brave_rewards/resources/ui/components/modalVerify/style.ts b/components/brave_rewards/resources/ui/components/modalVerify/style.ts index a338ffa4d97d..d131b6fc6932 100644 --- a/components/brave_rewards/resources/ui/components/modalVerify/style.ts +++ b/components/brave_rewards/resources/ui/components/modalVerify/style.ts @@ -44,7 +44,7 @@ export const StyledWalletIcon = styled<{}, 'div'>('div')` export const StyledHeaderText = styled<{}, 'div'>('div')` vertical-align: middle; display: inline-block; - padding-left: 22px; + padding: 3px 0 0 22px; ` export const StyledTitle = styled(Heading)` @@ -54,20 +54,12 @@ export const StyledTitle = styled(Heading)` font-weight: 600; ` -export const StyledSubtitle = styled(Heading)` - color: ${p => p.theme.palette.white}; - font-family: ${p => p.theme.fontFamily.body}; - font-size: 14px; - line-height: 24px; -` - export const StyledListTitle = styled(Heading)` font-weight: 600; font-size: 17px; line-height: 25px; - padding: 0 0 0 36px; + padding: 0; color: ${p => p.theme.palette.white}; - margin-bottom: -7px; ` export const StyledListItem = styled('div')` @@ -96,7 +88,7 @@ export const StyledButton = styled(Button as ComponentType)` padding: 11px 40px; width: auto; min-height: auto; - margin-top: -20px; + margin-top: -25px; ` export const StyledFooter = styled('div')` @@ -121,6 +113,7 @@ export const StyledContent = styled<{}, 'div'>('div')` export const StyledLeftSide = styled<{}, 'div'>('div')` width: 50%; padding-right: 10px; + margin-top: 9px; ` export const StyledRightSide = styled<{}, 'div'>('div')` diff --git a/components/resources/brave_components_strings.grd b/components/resources/brave_components_strings.grd index 77f7944613b4..ffa2c48a9d36 100644 --- a/components/resources/brave_components_strings.grd +++ b/components/resources/brave_components_strings.grd @@ -632,9 +632,8 @@ Withdraw BAT that you earn from viewing privacy-respecting ads Purchase additional BAT with credit cards and other sources Withdraw BAT that you may have previously added to your Brave Rewards wallet - Benefits of verifying - Ready to verify your wallet? - Verification is not necessary to contribute rewards to creators + But if you verify, you can... + Verifying your wallet is optional. Verified Uphold may require you to verify your identity based on services requested. Brave Software Inc. does not process, store, or access any of the personal information that you provide to Uphold when you establish an account with them.