Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave theme #351

Merged
merged 7 commits into from
Aug 24, 2018
Merged

Brave theme #351

merged 7 commits into from
Aug 24, 2018

Commits on Aug 24, 2018

  1. Make our theme color chosen at first

    @simonhong
    simonhong committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    902a241 View commit details
    Browse the repository at this point in the history

  2. Introduce brave theme type prefs 

    With kBraveThemeType, we can switch dark/light theme.
    @simonhong
    simonhong committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    1abed3d View commit details
    Browse the repository at this point in the history

  3. Call brave method for overring default theme color in GetColor 

    With this, theme extension have a chance to override theme color.
    @simonhong
    simonhong committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    cffca8d View commit details
    Browse the repository at this point in the history

  4. Subclassing ThemeService to override GetDefaultColor() 

    BraveThemeService became subclass of ThemeServiceAuraX11 and
ThemeServiceWin.
Also apis in theme_util.h are moved to static methods of
BraveThemeService.
    @simonhong
    simonhong committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    f98349c View commit details
    Browse the repository at this point in the history

  5. Remove BraveThemeTest.ObtainsBraveOverrideColors 

    This unittest can't be used because override is done in ThemeService.
BraveThemeServiceTest can cover this test.

Also static check is added to prevent other class should not use
newly defined DISALLOW_COPY_AND_ASSIGN.
    @simonhong
    simonhong committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    48f5558 View commit details
    Browse the repository at this point in the history

  6. Reverted to patching friend class 

    I tried to conditionally add friend statement in
DISALLOW_COPY_AND_ASSIGN.
However, I can't find how to do it in macro.
    @simonhong
    simonhong committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    450eacf View commit details
    Browse the repository at this point in the history

  7. Make BraveThemeService observe kBraveThemeType prefs

    @simonhong
    simonhong committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    e53cff5 View commit details
    Browse the repository at this point in the history