Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update patches for Chromium 69.0.3497.42 #332

Merged
merged 4 commits into from
Aug 17, 2018
Merged

Update patches for Chromium 69.0.3497.42 #332

merged 4 commits into from
Aug 17, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Aug 17, 2018

Fix brave/brave-browser#758

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@bbondy bbondy self-assigned this Aug 17, 2018
@bbondy bbondy requested a review from emerick August 17, 2018 14:22
@bbondy
Update grd files for 69.0.3497.42 rebase
bfc0b3e
@bbondy
Print l10n file that will be processed
6f5d1d2 
Instead of doing it after, because when it errors out it makes it easier to troubleshoot without adding extra logging.
@bbondy
Update l10n
3502d2c
emerick
emerick approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit b8f573d into master Aug 17, 2018
bbondy added a commit that referenced this pull request Aug 17, 2018
@bbondy
Fix build issue with extra strings
a3104cd 
Fixes pull request #332
@bbondy bbondy mentioned this pull request Aug 17, 2018
Merged
@bbondy bbondy deleted the 69.0.3497.42 branch August 20, 2018 01:38
@cezaraugusto cezaraugusto mentioned this pull request Jan 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbondy @emerick