"Brave Ads has arrived!" notification should be shown on Linux after upgrade from 0.62.x - 0.64.x #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
changed the title
tmancey
force-pushed
the
issues/4202-0.64.x
branch
from
23d64e0
to
968b78e
Compare
…ter upgrade from 0.62.x
tmancey
force-pushed
the
issues/4202-0.64.x
branch
from
968b78e
to
6ed0b04
Compare
bsclifton
approved these changes
May 8, 2019
There was a problem hiding this comment.
Jenkins had a little trouble with this PR - I took a look and saw that all platforms were building and tests were passing. The job (each time) got caught on something (my guess environment specific) and was terminated. Uploads were put on S3, tests did run as expected and passed. Going to approve 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift for #2321
Fixes brave/brave-browser#4202