Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shows supported region correctly for Ads on first load after upgrade. #2263

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 18, 2019

Fixes: brave/brave-browser#4154

Submitter Checklist:

Test Plan:

  1. Create a profile from a Brave browser version <0.63.x
  2. Copy that profile to the development path.
  3. Build and run from this pull request
  4. (For supported regions) navigate to brave://rewards and ensure that Ads is disabled, but no unsupported message is shown.
  5. (For un-supported regions) navigate to brave://rewards and ensure that Ads is disabled and the un-supported message is shown.

Additionally, ensure that Ads enabled state persists when restarting the browser, and through enabling and disabling Brave Rewards.

Ensure that behavior is appropriate on a clean profile path as well.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml merged commit bf219fe into master Apr 18, 2019
@ryanml ryanml deleted the fix-4154 branch April 18, 2019 11:14
tmancey pushed a commit that referenced this pull request Apr 18, 2019
Fix Shows supported region correctly for Ads on first load after upgrade.
tmancey pushed a commit that referenced this pull request Apr 18, 2019
Fix Shows supported region correctly for Ads on first load after upgrade.
tmancey pushed a commit that referenced this pull request Apr 18, 2019
Fix Shows supported region correctly for Ads on first load after upgrade.
tmancey pushed a commit that referenced this pull request Apr 18, 2019
Fix Shows supported region correctly for Ads on first load after upgrade.
tmancey pushed a commit that referenced this pull request Apr 19, 2019
Fix Shows supported region correctly for Ads on first load after upgrade.
tmancey pushed a commit that referenced this pull request Apr 19, 2019
Fix Shows supported region correctly for Ads on first load after upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ads shows region not supported on upgrade
2 participants