Get verified state from the list

[NejcZdovc]

Resolves brave/brave-browser#3780

Depends on brave/brave-browser#4025 and brave/brave-browser#3953

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Windows
  • macOS
  • Linux
• Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
  • Windows
  • macOS
  • Linux
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

• clean profie
• enable rewards
• go to http://duckduckgo.com/ site
• add monthly tip
• do one time tip
• make sure that panel is verified
• make sure that you see verified check in tips section
• make sure that you added site to ac table and that you see verified check
• close the browser
• go to publisher_list and change verified status of to false: from ["duckduckgo.com",true,false,{}] to ["duckduckgo.com",false,false,{}]
• start the browser
• make sure that on rewards page and in the panel you see unverified status now

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

[jasonrsadler]

Are we still using the publisher_info_database->publisher_info->verified column? It looks like we are updating publisher_info to save it for paper trail, but on data 'get', we replace it right away with list.

Other general comments left.

[NejcZdovc]

@jasonrsadler like we talked we can remove it, but this needs to be a separate PR as I would need to investigate what could potentially be broken

One last check

[tmancey]

@NejcZdovc is there a ticket for migrating to a database, as this is going to cause us no end of problems on iOS and Android, i.e. see https://drive.google.com/file/d/0B7Vx1OvzrLa3Y0R0X1BZbUpicGc/view We currently supportAndroid 4.4, and are moving to Android 5.1 due to 64 bit requirement however still memory limits are not high

[NejcZdovc]

@tmancey no issue yet as we didn't finalize the plan yet. We can define next week in person

[bridiver]

we can put the list in its own table and join if that works better than the field in the publisher_info table

[NejcZdovc]

yup this was my thinking as well. So this way we can remove publisher_list direct access completely and fetch everything from db and list just updates db every time we fetch it. So publisher banner would get data from db now as well (currently it's getting it directly from the list)