Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Vertical tabs on Beta channel by default (uplift to 1.51.x) #18065

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Enable Vertical tabs on Beta channel by default (uplift to 1.51.x) #18065

merged 1 commit into from
Apr 18, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 14, 2023 •
edited by kjozwiak
Loading

Uplift of #18006
Resolves brave/brave-browser#29658

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner April 14, 2023 05:21
@brave-builds brave-builds self-assigned this Apr 14, 2023
@brave-builds brave-builds added this to the 1.51.x - Beta milestone Apr 14, 2023
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Apr 14, 2023
@kjozwiak kjozwiak mentioned this pull request Apr 18, 2023
Closed
kjozwiak
kjozwiak approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.51.x approved 👍 QA has verified the PR on Nightly as per #18006 (comment).

@kjozwiak kjozwiak merged commit 776657e into 1.51.x Apr 18, 2023
@kjozwiak kjozwiak deleted the pr18006_sko/vtab-default_1.51.x branch April 18, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak