Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift of Onboarding: setting as default may break import flow (#17460) #17822

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Uplift of Onboarding: setting as default may break import flow (#17460) #17822

merged 1 commit into from
Mar 30, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 29, 2023 •
edited by kjozwiak
Loading

Uplift of #17460
Resolves brave/brave-browser#28787

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@spylogsster spylogsster requested a review from a team as a code owner March 29, 2023 16:31
@spylogsster spylogsster self-assigned this Mar 29, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Mar 29, 2023
@kjozwiak kjozwiak added this to the 1.50.x - Release milestone Mar 30, 2023
kjozwiak
kjozwiak approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.50.x approved 👍 QA has verified the PR on Nightly as per #17460 (comment)

@kjozwiak kjozwiak merged commit 59b17c0 into 1.50.x Mar 30, 2023
@kjozwiak kjozwiak deleted the pr17460_brave-28787_1.50.x branch March 30, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@spylogsster spylogsster

Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@spylogsster @kjozwiak