-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEVM support #17563
FEVM support #17563
Conversation
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Front-end!
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
Resolves brave/brave-browser#28954
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
Verification passed on
Update:
|
Merge pull request #17563 from brave/brave_28954_1 FEVM support Co-authored-by: Jocelyn Liu <yrliou@gmail.com>
Resolves brave/brave-browser#28954
Ethereum addrs supported on filecoin network using new Filecoin EVM tokens
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
At the moment only calibration network support etherium-like addresses.
You can get test filecoins from calibration faucet https://calibration-faucet.filswan.com/ on your eth account
by converting it's address by https://beryx.zondax.ch/address_converter and switching first letter f -> t
New tokens related to Filecoin EVM should be added.
Sending\Opening blockscan\Hiding\Showing should be tested.
Also it is important to test for an update from previous version - new tokens should be properly added