Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEVM support #17563

Merged
merged 2 commits into from
Mar 15, 2023
Merged

FEVM support #17563

merged 2 commits into from
Mar 15, 2023

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Mar 10, 2023

Resolves brave/brave-browser#28954

Ethereum addrs supported on filecoin network using new Filecoin EVM tokens

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

At the moment only calibration network support etherium-like addresses.
You can get test filecoins from calibration faucet https://calibration-faucet.filswan.com/ on your eth account
by converting it's address by https://beryx.zondax.ch/address_converter and switching first letter f -> t
New tokens related to Filecoin EVM should be added.
Sending\Opening blockscan\Hiding\Showing should be tested.
Also it is important to test for an update from previous version - new tokens should be properly added

@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Mar 10, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@cypt4 cypt4 marked this pull request as ready for review March 10, 2023 21:47
@cypt4 cypt4 requested review from a team as code owners March 10, 2023 21:47
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Front-end!

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@yrliou yrliou merged commit b75b5d8 into master Mar 15, 2023
@yrliou yrliou deleted the brave_28954_1 branch March 15, 2023 19:35
@github-actions github-actions bot added this to the 1.51.x - Nightly milestone Mar 15, 2023
cypt4 pushed a commit that referenced this pull request Mar 16, 2023
@cypt4 cypt4 mentioned this pull request Mar 16, 2023
7 tasks
@srirambv
Copy link
Contributor

srirambv commented Mar 24, 2023

Verification passed on

Brave 1.51.57 Chromium: 112.0.5615.29 (Official Build) nightly (64-bit)
Revision 8a59304c62e066962363d2fd8edd8e7b459c42bd-refs/branch-heads/5615@{#497}
OS Linux
  • Verified steps from PR
  • Verified upon upgrade to 1.51.57, Filecoin EVM Mainnet -0x13a https://api.node.glif.io/rpc/v1 & Filecoin EVM Testnet - 0x4cb2f https://api.calibration.node.glif.io/rpc/v1 is shown under network list
  • Verified Filecoin EVM Mainnet is enabled by default and Filecoin EVM Testnet is disabled by default
  • Verified able to send FIL on Filecoin EVM Testnet from one account to another
  • Verified clicking on View on blockchain explorer loads the correct block explorer
  • Verified sent transaction is listed under activity tab
  • Verified selecting FIL on Filecoin EVM Mainnet/Testnet shows all the accounts that hold the balance of the token
  • Verified able to hide network and hide the token from portfolio page
Transaction Upgrade scenario
17563.mp4
17563-Upgrade.mp4

Update:

  • Verified able to send FIL on FEVM Mainnet
  • Verified able to load block explorer from transaction menu/panel
  • Verified able to show/hide token from portfolio page
  • Eth Transaction Hash 0xb07b4bd8a66d58feadedfcc9d499d12f5d384acfb2de707a36fbab88c7083abd

image

image

kjozwiak pushed a commit that referenced this pull request Mar 24, 2023
Merge pull request #17563 from brave/brave_28954_1

FEVM support

Co-authored-by: Jocelyn Liu <yrliou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Filecoin EVM to preloaded networks
5 participants