Verify NFT content media type before pinning #17392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -222,7 +222,8 @@ enum WalletPinServiceErrorCode { | |||
| ERR_WRONG_METADATA_FORMAT = 4, | |||
| ERR_ALREADY_PINNED = 5, | |||
| ERR_NOT_PINNED = 6, | |||
| ERR_PINNING_FAILED = 7 | |||
| ERR_PINNING_FAILED = 7, | |||
| ERR_MEDIA_TYPE_UNSUPORTED = 8 | |||
There was a problem hiding this comment.
UNSUPORTED ->
UNSUPPORTED
| @@ -149,11 +152,94 @@ std::string BraveWalletPinService::ErrorCodeToString( | |||
| return "ERR_NOT_PINNED"; | |||
| case mojom::WalletPinServiceErrorCode::ERR_PINNING_FAILED: | |||
| return "ERR_PINNING_FAILED"; | |||
| case mojom::WalletPinServiceErrorCode::ERR_MEDIA_TYPE_UNSUPORTED: | |||
| return "ERR_MEDIA_TYPE_UNSUPORTED"; | |||
Comment on lines
603
to
611
| content_type_checker_->CheckContentTypeSupported( | ||
| *image_url, | ||
| base::BindOnce(&BraveWalletPinService::OnContentTypeChecked, | ||
| weak_ptr_factory_.GetWeakPtr(), std::move(service), | ||
| std::move(token), std::move(cids), | ||
| std::move(callback))); |
There was a problem hiding this comment.
This needs S&P review as we are getting arbitrary url resource from blockchain and forcing browser to make a request to it.
There was a problem hiding this comment.
It is a bit different : actually we make a call to the IPFS gateway which we use to fetch metadata on the previous step. Final url looks like https://ipfs.io/CID/...
There was a problem hiding this comment.
I think it's fine. It's not arbitrary, like @cypt4 said and we only call IPFS gateway. This code also doesn't fetch a file, only response headers.
|
|
||
| raw_ptr<PrefService> pref_service_; | ||
| scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory_; | ||
| // Reports that are actively being sent. |
stoletheminerals
approved these changes
Mar 6, 2023
|
Verification passed on
|
kjozwiak
pushed a commit
that referenced
this pull request
Mar 16, 2023
Uplift of #17392 (squashed) to beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#28775
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
After an NFT added to the wallet, media type of the "image" field is checked. So if it differs from "image/.." NFT won't be pinned. Probably we can test this by sniffing NFT gateway for the https://nftstorage.link(example)/ipfs/IMAGE_CID request by changing content_type here from image/png to blablabla