Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): View Contract in Transaction Panel #17333

Merged
merged 1 commit into from
Feb 23, 2023
Merged

fix(wallet): View Contract in Transaction Panel #17333

merged 1 commit into from
Feb 23, 2023

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Feb 22, 2023 •
edited by josheleonard
Loading

Description

Adds the ability to view the Contract of a transaction you are signing.

Resolves brave/brave-browser#27188

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Setup wallet
  2. Setup https://github.com/bbondy/eth-manual-tests
  3. Change to the Goerli Test Network and visit http://localhost:8081/request.html
  4. Click ethereum.enable and grant permission
  5. Fill the to address next to eth_signTransaction with another Wallet Address and then click eth_signTransaction
  6. The confirm panel should popup and the From -> To address should look normal
  7. Reject the transaction.
  8. Fill the to address next to eth_signTransaction with 0x121FD74f3e8b5D5409D65535b19a86E3aEF20E42 (Bubble Farming) and then click eth_signTransaction
  9. The confirm panel should popup and then To address should change to Contract address
  10. Click on the Address and it should route you to the block-explorer where you can read the contract information for (Bubble Framing).
  11. Reject the transaction.
ContractAddress.mov

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner February 22, 2023 19:32
@Douglashdaniel Douglashdaniel self-assigned this Feb 22, 2023
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 22, 2023
@Douglashdaniel Douglashdaniel requested a review from a team February 22, 2023 19:32
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the view-contract-in-transaction-panel branch from d31ca1a to 56d656d Compare February 22, 2023 20:47
josheleonard
josheleonard approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the view-contract-in-transaction-panel branch from 56d656d to 05c6fda Compare February 22, 2023 22:20
@Douglashdaniel Douglashdaniel force-pushed the view-contract-in-transaction-panel branch from 05c6fda to efe1394 Compare February 22, 2023 22:33
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit 27caa02 into master Feb 23, 2023
@Douglashdaniel Douglashdaniel deleted the view-contract-in-transaction-panel branch February 23, 2023 00:28
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 23, 2023
@bbondy
Copy link
Member

bbondy commented Feb 23, 2023

pls uplift

@Douglashdaniel Douglashdaniel mentioned this pull request Mar 1, 2023
Merged
7 tasks
Douglashdaniel added a commit that referenced this pull request Mar 2, 2023
@Douglashdaniel
Merge pull request #17333 from brave/view-contract-in-transaction-panel
348559d 
fix(wallet): View Contract in Transaction Panel
@srirambv
Copy link
Contributor

srirambv commented Mar 2, 2023

Verification passed on

Brave 1.50.74 Chromium: 111.0.5563.41 (Official Build) nightly (64-bit)
Revision 976ef12907ef9b413c2d929c043307b415d27b9e-refs/branch-heads/5563@{#737}
OS Linux
  • Verified steps from PR
  • Verified when a contract address is used for sign transaction it updates the address to show as contract address
  • Verified clicking on the contract address loads block explorer and sets focus to the code section on the page
  • Encountered #28849
17333.mp4

kjozwiak pushed a commit that referenced this pull request Mar 2, 2023
@Douglashdaniel @bbondy
fix(wallet): View Contract in Transaction Panel (uplift to 1.49.x) (#…
9050e4d 
…17426)

* Add eth_getCode support for getting address bytecode (#17215)

This is intended to be used to check if an address is an EOA or a contract

You can query
```js
const apiProxy = getWalletPanelApiProxy()
const jsonRpcService = apiProxy.jsonRpcService
console.log('BAT rpc service get code: ', await jsonRpcService.getCode('0x0d8775f648430679a709e98d2b0cb6250d2887ef', BraveWallet.CoinType.ETH, '0x1'))
console.log('EOA rpc service get code: ', await jsonRpcService.getCode('0x...', BraveWallet.CoinType.ETH, '0x1'))
```

This would output the bytecode in hex format for the BAT price and the
string 0x for the EOA address.

* Merge pull request #17333 from brave/view-contract-in-transaction-panel

fix(wallet): View Contract in Transaction Panel

---------

Co-authored-by: Brian R. Bondy <netzen@gmail.com>
@srirambv srirambv mentioned this pull request Mar 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diracdeltas diracdeltas diracdeltas approved these changes

@josheleonard josheleonard josheleonard approved these changes

Assignees

@Douglashdaniel Douglashdaniel

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging this pull request may close these issues.

There is no way for a user to learn the contract address they are signing a transaction for
6 participants
@Douglashdaniel @brave-builds @bbondy @srirambv @diracdeltas @josheleonard