-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error message: Brave needs Windows 10, not 7/8 #17234
Conversation
@mkarolin: @goodov said I should ask you for a review here. I hand-edited the files. @goodov pointed out that the header in |
@mherrmann I think that https://github.com/brave/brave-browser/wiki/Strings-and-Localization may help to explain it a little. |
@emerick thank you for the comment. Would you please explain in a little more detail? I could trial & error various approaches for hours but feel like you might be able to give the answer in minutes. Do I just add my override for
|
@mherrmann typically with strings we'd use our own strings file (such as One thing to note though, since you change the message content the translations id attribute won't match any more. With the new content the |
This reverts commit d8aa68f95eb13f538cb636dc2dc22d094a208543.
d8aa68f
to
18fc0b6
Compare
Thank you @mkarolin, I'll follow the approach you suggested. |
This fixes `npm run presubmit`.
Still works and @mkarolin can I ask for your review? |
Nevermind @mkarolin, I still need to fix it for other languages. Sorry. Please hold off with the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kjozwiak should this be uplifted? |
Apologies for the late response. Just seeing this now, lets get it uplifted into |
No problem; I'm on PTO this week and could only create the uplift next week, unfortunately. |
no worries 👍 We can leave this in either |
Verification PASSED on Using https://github.com/brave/brave-browser/releases/tag/v1.51.13, downloaded both
|
Example |
Example |
---|---|
BraveBrowserStandaloneNightlySetup32.exe
Example |
Example |
---|---|
Resolves brave/brave-browser#28511
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Please see brave/brave-browser#28511.