Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure solana_provider_ is connected before checking IsSolanaKeyringCreated #16928

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Jan 30, 2023

Resolves brave/brave-browser#28147

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

STR in the issue

@darkdh darkdh requested a review from a team as a code owner January 30, 2023 22:55
@darkdh darkdh self-assigned this Jan 30, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Jan 31, 2023

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.49.78 Chromium: 110.0.5481.52 (Official Build) nightly (64-bit)
-- | --
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Windows 11 Version 22H2 (Build 22621.1105)

Using the STR/Cases outlined via brave/brave-browser#28147 (comment), ensured that Brave wasn't crashing when visiting the following websites:

Also ensured that opening the wallet via the Brave Wallet panel didn't cause the browser to crash as it did before.


Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.49.79 Chromium: 110.0.5481.52 (Official Build) canary (32-bit)
--- | ---
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Android 13; Build/TQ1A.230105.002

Using the STR/Cases outlined via brave/brave-browser#28147 (comment), ensured that Brave wasn't crashing when visiting the following websites:

Also ensured that opening Wallet from the Hamburger Menu didn't cause any issues/crashes.

kjozwiak pushed a commit that referenced this pull request Jan 31, 2023
…reated (uplift to 1.48.x) (#16937)

Uplift of #16928 (squashed) to beta
kjozwiak pushed a commit that referenced this pull request Jan 31, 2023
…reated (uplift to 1.47.x) (#16938)

Uplift of #16928 (squashed) to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solana provider renderer crash
3 participants