Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an Add Widget button on Android 8 devices #16923

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Jan 30, 2023

Resolves brave/brave-browser#27825

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Make a fresh install of Brave on Android 8
  2. Observe that the Add Widget button from the issue looks good.

@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 30, 2023
@SergeyZhukovsky SergeyZhukovsky self-assigned this Jan 30, 2023
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 . Also verified on my Samsung Note8 that issue is fixed in this branch.

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjozwiak
Copy link
Member

Reproduced the original issue on Pixel 6 Pro running Android 8 via the Android Studio Emulator as per the following:

Brave | 1.49.76 Chromium: 110.0.5481.52 (Official Build) canary (32-bit) 
--- | ---
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Android 8.0.0; Build/OSR1.180418.026

image

Verification PASSED on Pixel 6 Pro running Android 8 via the Android Studio Emulator using the following build(s):

Brave | 1.49.77 Chromium: 110.0.5481.52 (Official Build) canary (32-bit) 
--- | ---
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Android 8.0.0; Build/OSR1.180418.026
  • ensured that tapping on Add Widget via the onborading worked without any issues
  • ensured that tapping on Not now correctly dismissed the widget onboarding without any issues
Example Example
image image

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.49.77 Chromium: 110.0.5481.52 (Official Build) canary (32-bit)
--- | ---
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Android 13; Build/TQ1A.230105.002
  • ensured that tapping on Add Widget via the onborading worked without any issues
  • ensured that tapping on Not now correctly dismissed the widget onboarding without any issues
Example Example
Screenshot_20230131-020527 Screenshot_20230131-020549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Not now" off the screen in portrait mode
5 participants