Fix BraveCompoundTabContainer layout for vertical tab strip #16885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonok-edm
approved these changes
Jan 27, 2023
sangwoo108
force-pushed
the
sko/vtab-rebase
branch
from
65c5d1e
to
378282c
Compare
|
|
1 similar comment
|
|
|
|
|
|
sangwoo108
force-pushed
the
sko/vtab-rebase
branch
from
17e7ff3
to
82670b8
Compare
sangwoo108
commented
Jan 27, 2023
| ad_block_client_->setupDiscardPolicy(*regex_discard_policy_); | ||
| } |
There was a problem hiding this comment.
I have no idea why presubmit complains about this formatting, even I didn't touch this file and the previous version looks good for me. 🤷
mihaiplesa
force-pushed
the
sko/vtab-rebase
branch
from
ecd76d0
to
dcb2ff6
Compare
|
|
mihaiplesa
added
CI/skip-linux
CI/skip-macos-x64
sangwoo108
force-pushed
the
sko/vtab-rebase
branch
from
dcb2ff6
to
586f949
Compare
In the latest Chromium, CompoundTabContainer doesn't use FlexLayout. But in our use case, FlexLayout does good so make things work based on the FlexLayout. Related upstream changes: https://chromium-review.googlesource.com/c/chromium/src/+/4081180 https://chromium-review.googlesource.com/c/chromium/src/+/3956548
sangwoo108
force-pushed
the
sko/vtab-rebase
branch
from
586f949
to
ab51949
Compare
emerick
pushed a commit
that referenced
this pull request
Jan 31, 2023
In the latest Chromium, CompoundTabContainer doesn't use FlexLayout. But in our use case, FlexLayout does good so make things work based on the FlexLayout. Related upstream changes: https://chromium-review.googlesource.com/c/chromium/src/+/4081180 https://chromium-review.googlesource.com/c/chromium/src/+/3956548
kjozwiak
pushed a commit
that referenced
this pull request
Feb 1, 2023
* Merge pull request #16324 from brave/cr110 Upgrade from Chromium 109 to Chromium 110 * [Android] Fix for crash or no action on page bookmark * Merge pull request #16922 from brave/bsc-fix-microtask-crash Update calls for v8 microscope; skus_js_handler had webview crash * Fix BraveCompoundTabContainer layout for vertical tab strip (#16885) In the latest Chromium, CompoundTabContainer doesn't use FlexLayout. But in our use case, FlexLayout does good so make things work based on the FlexLayout. Related upstream changes: https://chromium-review.googlesource.com/c/chromium/src/+/4081180 https://chromium-review.googlesource.com/c/chromium/src/+/3956548 * Merge pull request #16942 from brave/cr110-followup-remove-block-third-party-cookies-in-private Re-hide "Block third-party cookies in Private" option in brave://settings * Merge pull request #16944 from brave/onboarding-bug Added chrome resource url on onboarding webui csp * [Android] Fix for search engine logo on NTP --------- Co-authored-by: Artem Samoilenko <artem@brave.com> Co-authored-by: Brian Clifton <brian@clifton.me> Co-authored-by: Sangwoo Ko <sko@brave.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest Chromium, CompoundTabContainer doesn't use FlexLayout. But in our use case, FlexLayout does good so make things work based on the FlexLayout.
Related upstream changes:
https://chromium-review.googlesource.com/c/chromium/src/+/4081180
https://chromium-review.googlesource.com/c/chromium/src/+/3956548
Resolves brave/brave-browser#28084
Many thanks to @antonok-edm for reporting this!
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
None