Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 109 to Chromium 110 #16324

Merged
merged 146 commits into from
Jan 26, 2023
Merged

Upgrade from Chromium 109 to Chromium 110 #16324

merged 146 commits into from
Jan 26, 2023

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Dec 11, 2022

Resolves brave/brave-browser#27221

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-draft CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Dec 11, 2022
@emerick emerick force-pushed the cr110 branch 5 times, most recently from d99cb4d to 2cad654 Compare January 1, 2023 14:34
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

⚠️ PR head is an unsigned commit
commit: d58556f
reason: unsigned
Please follow the handbook to configure commit signing
cc: @cdesouza-chromium

samartnik and others added 13 commits January 25, 2023 07:42
Chromium change:
chromium/chromium@6e07489

Clean up code related DownloadLater feature
This feature is not launched, remove all related code.

BUG=1337109

Change-Id: Ie602ecf5e93d16d7fdfd0229da7e13cd50fef0b5
Chromium change:

https://source.chromium.org/chromium/chromium/src/+/ce31565127aa823f714e6bf7547ef48188cdc90f

commit ce31565127aa823f714e6bf7547ef48188cdc90f
Author: Dave Tapuska <dtapuska@chromium.org>
Date:   Fri Dec 2 16:46:13 2022 +0000

    Enable Microtask queues per WindowAgent.

    Each WindowAgent having its own microtask queue aligns with the
    specification. All code has been converted to use the EventLoop for
    queuing and running microtasks.

    This is a reland of crrev.com/01e7a24c. The original change was reverted
    due to a V8 Debugger issue using the wrong microtask queue to register
    its completion callback. That has since been fixed in v8 (https://chromium-review.googlesource.com/c/v8/v8/+/4062397).

    BUG=961186
These tests regressed in cr110. A follow up issue is created to fix them brave/brave-browser#27837
Otherwise there is incomplete type compile error.
Chromium change:
chromium/chromium@b1683dc

Replace org.chromium.base.Consumer with Java's (except in chromecast/)
No behavior is changed.
Most changes are trivial automated replacement of the imports.
This was unblocked by the default min SDK being bumped to 24 in
crrev.com/c/4000311.
The corresponding bump in chromecast/ (crrev.com/c/3928245) needs more
time to stick for sure, so org.chromium.base.Consumer is moved to
org.chromium.chromecast.base.* for the moment.

Bug: 1034012
@emerick emerick merged commit 98d99f0 into master Jan 26, 2023
@emerick emerick deleted the cr110 branch January 26, 2023 14:12
@emerick emerick added this to the 1.49.x - Nightly milestone Jan 26, 2023
emerick added a commit that referenced this pull request Jan 27, 2023
Upgrade from Chromium 109 to Chromium 110
emerick added a commit that referenced this pull request Jan 31, 2023
Upgrade from Chromium 109 to Chromium 110
kjozwiak pushed a commit that referenced this pull request Feb 1, 2023
* Merge pull request #16324 from brave/cr110

Upgrade from Chromium 109 to Chromium 110

* [Android] Fix for crash or no action on page bookmark

* Merge pull request #16922 from brave/bsc-fix-microtask-crash

Update calls for v8 microscope; skus_js_handler had webview crash

* Fix BraveCompoundTabContainer layout for vertical tab strip (#16885)

In the latest Chromium, CompoundTabContainer doesn't use FlexLayout.
But in our use case, FlexLayout does good so make things work based
on the FlexLayout.

Related upstream changes:
https://chromium-review.googlesource.com/c/chromium/src/+/4081180
https://chromium-review.googlesource.com/c/chromium/src/+/3956548

* Merge pull request #16942 from brave/cr110-followup-remove-block-third-party-cookies-in-private

Re-hide "Block third-party cookies in Private" option in brave://settings

* Merge pull request #16944 from brave/onboarding-bug

Added chrome resource url on onboarding webui csp

* [Android] Fix for search engine logo on NTP

---------

Co-authored-by: Artem Samoilenko <artem@brave.com>
Co-authored-by: Brian Clifton <brian@clifton.me>
Co-authored-by: Sangwoo Ko <sko@brave.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 109 to Chromium 110