Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test, fails similarly to ReparentingPinsHomeTab. #15648

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented Oct 25, 2022

The test fails similarly to WebAppTabStripBrowserTest.ReparentingPinsHomeTab.
Underlying issue is most likely this: brave/brave-browser#22021, because no brave-specific mojo endpoints are available for renderer (see BraveMainDelegate::CreateContentBrowserClient and BraveContentBrowserClient implementation).

Resolves brave/brave-browser#26031

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov requested a review from emerick October 25, 2022 05:53
@goodov goodov self-assigned this Oct 25, 2022
@goodov goodov enabled auto-merge October 25, 2022 10:12
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goodov goodov merged commit 474a490 into master Oct 25, 2022
@goodov goodov deleted the issues/26031 branch October 25, 2022 11:03
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: WebAppTabStripBrowserTest.NavigationThrottle
2 participants