Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #1188 from brave/sync_frequent_initial_update" #1532

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Feb 1, 2019

This reverts commit f005c59, reversing
changes made to 9c45f2f.

fix brave/brave-browser#3182

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@darkdh darkdh requested a review from bbondy February 1, 2019 00:49
@darkdh darkdh self-assigned this Feb 1, 2019
@darkdh darkdh merged commit 02850d6 into master Feb 1, 2019
darkdh added a commit that referenced this pull request Feb 1, 2019
Revert "Merge pull request #1188 from brave/sync_frequent_initial_update"
@darkdh darkdh added this to the 0.62.x - Nightly milestone Feb 1, 2019
@darkdh darkdh deleted the sync-revert branch February 1, 2019 00:56
darkdh added a commit that referenced this pull request Feb 1, 2019
Revert "Merge pull request #1188 from brave/sync_frequent_initial_update"
darkdh added a commit that referenced this pull request Feb 1, 2019
Revert "Merge pull request #1188 from brave/sync_frequent_initial_update"
bbondy added a commit that referenced this pull request Feb 1, 2019
Merge pull request #1532 from brave/sync-revert
bbondy added a commit that referenced this pull request Feb 1, 2019
Merge pull request #1532 from brave/sync-revert
bbondy added a commit that referenced this pull request Feb 1, 2019
Merge pull request #1532 from brave/sync-revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync chain creator does not get some bookmarks on initial sync
2 participants