Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Brave Ads redundant new tab page ad wallpaper validation #15122

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Remove Brave Ads redundant new tab page ad wallpaper validation #15122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions vendor/bat-native-ads/src/bat/ads/internal/ads/serving/new_tab_page_ad_serving.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,6 @@ void Serving::ServeAd(const NewTabPageAdInfo& ad,
return;
}

if (ad.wallpapers.empty()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this check can help us to avoid the crash in case of wrong data came from the server catalog.

BLOG(1, "Failed to serve new tab page ad due to missing wallpapers");
callback(/*ads*/ absl::nullopt);
return;
}

BLOG(1, "Served new tab page ad:\n"
<< " placementId: " << ad.placement_id << "\n"
<< " creativeInstanceId: " << ad.creative_instance_id << "\n"
Expand Down