Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translate] Fix zh-CN lang code #15105

Merged
merged 1 commit into from
Sep 15, 2022
Merged

[translate] Fix zh-CN lang code #15105

merged 1 commit into from
Sep 15, 2022

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Sep 15, 2022

Resolves brave/brave-browser#25417

This PR changes the default in the code.
The older browser versions also will receive the new list via Griffin: brave/brave-variations#366.
But the default list is still used for restored pages (a Chromium thing, the startup pages usually load faster than the language list request).

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@@ -13,8 +13,8 @@ namespace translate {

namespace {
const char* const kBraveDefaultLanguageList[] = {
"de", "en", "es", "fr", "hi", "it", "ja", "nl",
"pl", "pt", "ro", "ru", "tr", "vi", "zh-Hans",
"de", "en", "es", "fr", "hi", "it", "ja", "nl",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a weigh formatting for clang-format.
BTW we will soon delete this file (after enabling the all languages)

Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have tests?

@atuchin-m
Copy link
Collaborator Author

don't we have tests?
@iefremov it's mostly hardcoded data than a code/state machine that could be tested.
We could write a test that kBraveDefaultLanguageList is actually used, but this src override was designed as temporary (until we support all the Chromium languages).

@atuchin-m atuchin-m merged commit f5ebd78 into master Sep 15, 2022
@atuchin-m atuchin-m deleted the fix-zh-CN-lang-code branch September 15, 2022 14:44
@github-actions github-actions bot added this to the 1.45.x - Nightly milestone Sep 15, 2022
"de", "en", "es", "fr", "hi", "it", "ja", "nl",
"pl", "pt", "ro", "ru", "tr", "vi", "zh-Hans",
"de", "en", "es", "fr", "hi", "it", "ja", "nl",
"pl", "pt", "ro", "ru", "tr", "vi", "zh-CN",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add "zh-TW" to default list?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linhkikuchi
Hm, I can't see that it's supported on https://translate.brave.com/translate_a/l

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix zh-CN lang code for Translate feature
3 participants