-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[translate] Fix zh-CN lang code #15105
Conversation
@@ -13,8 +13,8 @@ namespace translate { | |||
|
|||
namespace { | |||
const char* const kBraveDefaultLanguageList[] = { | |||
"de", "en", "es", "fr", "hi", "it", "ja", "nl", | |||
"pl", "pt", "ro", "ru", "tr", "vi", "zh-Hans", | |||
"de", "en", "es", "fr", "hi", "it", "ja", "nl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a weigh formatting for clang-format.
BTW we will soon delete this file (after enabling the all languages)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we have tests?
|
"de", "en", "es", "fr", "hi", "it", "ja", "nl", | ||
"pl", "pt", "ro", "ru", "tr", "vi", "zh-Hans", | ||
"de", "en", "es", "fr", "hi", "it", "ja", "nl", | ||
"pl", "pt", "ro", "ru", "tr", "vi", "zh-CN", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also add "zh-TW"
to default list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@linhkikuchi
Hm, I can't see that it's supported on https://translate.brave.com/translate_a/l
Resolves brave/brave-browser#25417
This PR changes the default in the code.
The older browser versions also will receive the new list via Griffin: brave/brave-variations#366.
But the default list is still used for restored pages (a Chromium thing, the startup pages usually load faster than the language list request).
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: