Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various balance fixes for FIL #14912

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Various balance fixes for FIL #14912

merged 1 commit into from
Sep 8, 2022

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Aug 31, 2022 •
edited
Loading

Resolves brave/brave-browser#24947

  1. Changed calibration api url
  2. Fixed a bug when balance was not loading for mainnet if wallet opened with selected testnet acc.
  3. When open account info for filecoin only supported networks are showing for now(mainnet for f* and testnet\localhost for t*).

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Check that filecoin testnet shows balance and accepts transactions.
  2. Check that there is no 0 balance error with mainnet when wallet is opened with selected filecoin testnet
  3. Check that the account info screen for filecoin contains only related networks.
  4. Check that the account info screen for sol and eth shows correct data.

@cypt4 cypt4 requested a review from a team as a code owner August 31, 2022 08:33
@cypt4 cypt4 force-pushed the brave_24947 branch 2 times, most recently from 5a13011 to 8979c6a Compare August 31, 2022 10:55
supermassive
supermassive reviewed Sep 1, 2022
View reviewed changes
components/brave_wallet_ui/common/async/lib.ts Outdated
@@ -274,6 +275,17 @@ export const getAllBuyAssets = async (): Promise<{
return results
}

export function getFilecoinKeyringIdFromNetwork (network: BraveWallet.NetworkInfo) {
if (network.coin !== CoinType.FIL) {
Copy link
Collaborator

@supermassive supermassive Sep 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BraveWallet.CoinType.FIL and no need in import above

Douglashdaniel
Douglashdaniel approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Front-end

@cypt4
Various balance fixes for FIL
7102157 
Resolves brave/brave-browser#24947
1) Changed calibration api url
2) Fixed a bug when balance was not loading for mainnet if wallet opened with selected testnet acc.
3) When open account info for filecoin only supported networks are showing for now(mainnet for f* and testnet\localhost for t*).
@cypt4 cypt4 merged commit 22c0846 into master Sep 8, 2022
@cypt4 cypt4 deleted the brave_24947 branch September 8, 2022 12:45
@github-actions github-actions bot added this to the 1.45.x - Nightly milestone Sep 8, 2022
@srirambv srirambv mentioned this pull request Oct 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supermassive supermassive supermassive approved these changes

@Douglashdaniel Douglashdaniel Douglashdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.45.x - Release
Development

Successfully merging this pull request may close these issues.

Only show current network and localhost for Filecoin
3 participants
@cypt4 @supermassive @Douglashdaniel