Welcome screen locale ampersand fix #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rossmoody please update only |
rossmoody
force-pushed
the
welcome-fix
branch
from
d809865
to
ff43838
Compare
rossmoody
force-pushed
the
welcome-fix
branch
from
ff43838
to
7fe5870
Compare
NejcZdovc
approved these changes
Jan 24, 2019
|
We'll want to get this into 0.59.x; will submit both uplift requests here in a moment |
|
@bsclifton note that master is now on 0.62, so you need 3 PR's |
bsclifton
pushed a commit
that referenced
this pull request
Jan 24, 2019
Welcome screen locale ampersand fix
bsclifton
pushed a commit
that referenced
this pull request
Jan 24, 2019
Welcome screen locale ampersand fix
bsclifton
pushed a commit
that referenced
this pull request
Jan 24, 2019
Welcome screen locale ampersand fix
This was referenced Jan 24, 2019
|
@NejcZdovc thanks for the reminder! Submitted 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#3068