Desktop UI for Solana signAndSendTransaction, signTransaction, and signAllTransactions provider APIs

[josheleonard]

Resolves brave/brave-browser#23369
Resolves brave/brave-browser#23434

Security review request: https://github.com/brave/security/issues/910

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

1. Create a new Wallet, select Solana Devnet and then create a Solana Account if needed.
2. Go to https://solfaucet.com/ , paste your Solana address and click Devnet to get some Devnet Solana Tokens
3. Go back to the Brave Wallet and make sure you have received your Devnet tokens in your wallet.
4. Ask @Douglashdaniel for a shared test wallet or message @yrliou to send you some SPL tokens on the Solana Devnet (you will need to add this token as a custom token in the Edit Visible Asset modal.)
5. Go to https://pwgoom.csb.app/ and click Connect, connect your wallet!

Testing - Sign and Send Transaction

1. Click Sign and Send Transaction.

2. Check and make sure Transaction info is displayed.

3. Click Details and make sure transaction Details are displayed.

4. Click Confirm and make sure you can see the Transaction Details

Testing - Sign and Send Transaction (Request)

1. Click on Sign and Send Transaction (Request)

2. Follow the same instructions for Testing - Sign and Send Transaction from 2-4

Testing - Sign and Send SPL Token Transaction

1. Click Sign and Send SPL Token Transaction.

2. Check and make sure Transaction info is displayed.

3. Click Details and make sure transaction Details are displayed.

4. Click Confirm and make sure you can see the Transaction Details

Testing - Sign Transaction

1. Click Sign Transaction.

2. Review Sign at your own risk warning and click Continue

3. Review Details and click Sign

Testing - Sign Transaction (Request)

1. Click on Sign Transaction (Request)

2. Follow the same instructions for Sign Transaction from 2-3

Testing - Sign All Transaction (multiple)

1. Click on Sign All Transaction (multiple)

2. Review Sign at your own risk warning and click Continue

3. Review Details and make sure that there are multiple transactions, then click Sign

Testing - Sign All Transaction (multiple) (Request)

1. Click on Sign All Transaction (multiple) (Request)

2. Follow the same instructions for Sign All Transaction (multiple) from 2-3

Testing - Sign All Transaction (single)

1. Click on Sign All Transaction (single)

2. Review Sign at your own risk warning and click Continue

3. Review Details and make sure that there is a single transaction, then click Sign

Testing - Sign All Transaction (single) (Request)

1. Click on Sign All Transaction (single) (Request)

2. Follow the same instructions for Sign All Transaction (single) from 2-3

[Douglashdaniel]

Should these panels show Solana Testnet when doing a Testnet transaction?

Screen.Recording.2022-06-12.at.11.00.38.PM.mov

[yrliou]

For non-system instructions which we don't support decode yet, currently it looks like this: (it's a SPL token transfer in this case)

I think it's probably better if we can display more details, like showing raw data arrays and account lists.

[josheleonard]

Approved @Douglashdaniel's changes

[srirambv]

Verification passed on

Brave	1.42.24 Chromium: 103.0.5060.53 (Official Build) nightly (64-bit)
Revision	a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS	Windows 11 Version 21H2 (Build 22000.739)

• Verified test plan from PR
• Verified able to sign and send transactions (single/multiple)
• Encountered brave-browser#23663 & brave-browser#23664

13666.mp4