Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Brave Ads launch notification for existing Rewards users #1365

Merged
merged 5 commits into from
Apr 20, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jan 17, 2019

Fixes: brave/brave-browser#2914
UI PR: brave/brave-ui#346

Note: This is only intended to be shown to existing users of Rewards who have not enabled Ads yet

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Use a <0.63 version of Brave to create a profile.
  2. Using the older version, simply enable rewards and do nothing else
  3. Create a copy of the profile appropriately titled Brave-Browser-Development
  4. Build version from this PR (passing --brave-ads-debug as a flag, this reduces the time to delete notification from 7 days to 5 mins) and start Brave
  5. Navigate to the panel and confirm that the Ads notification prompting the user to turn on ads is available
  6. Confirm that click "Turn on ads" takes you to brave://rewards and dismisses the notification. (Note this will just navigate to the page, it will not automatically enable Ads)
  7. Restart browser
  8. Confirm that the notification is not available

Run through the above steps again, except after step 2, disable Rewards before copying the profile. Ensure that when upgrading the notification is not shown.

Also, test this with a clean profile. Opt-in to Rewards, confirm that you don't get the notification (opting in enables ads)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

cc: @mandar-brave @jsecretan

package.json Outdated Show resolved Hide resolved
@ryanml
Copy link
Contributor Author

ryanml commented Jan 17, 2019

@bridiver naming updates made

@ryanml ryanml merged commit ed63eb6 into master Apr 20, 2019
@ryanml ryanml deleted the fix-2914-2 branch April 20, 2019 02:22
@NejcZdovc NejcZdovc added this to the 0.66.x - Nightly milestone Apr 20, 2019
NejcZdovc added a commit that referenced this pull request Apr 20, 2019
This reverts commit ed63eb6, reversing
changes made to e71bcdd.
NejcZdovc added a commit that referenced this pull request Apr 20, 2019
Revert "Merge pull request #1365 from brave/fix-2914-2"
@NejcZdovc NejcZdovc restored the fix-2914-2 branch April 20, 2019 17:21
@NejcZdovc NejcZdovc deleted the fix-2914-2 branch April 20, 2019 17:22
NejcZdovc pushed a commit that referenced this pull request Apr 20, 2019
Adds Brave Ads launch notification for existing Rewards users
@NejcZdovc NejcZdovc mentioned this pull request Apr 23, 2019
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify existing opted in Brave Rewards users of Brave Ads launch
6 participants