Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relaunch option for inline tip settings in brave://settings/rewards #11157

Merged

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Nov 18, 2021

Resolves brave/brave-browser#19564

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Clean profile
  • Visit brave://settings/rewards
  • Click option to launch Rewards panel
  • Enable Rewards
  • Toggle one of the inline tip options (Twitter/Github/Reddit)
  • Ensure that Relaunch button appears
  • Press Relaunch button
  • Ensure that Brave relaunches as expected

@emerick emerick self-assigned this Nov 18, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Nov 23, 2021

Verification PASSED on Win 11 x64 using the following build:

Brave | 1.34.28 Chromium: 96.0.4664.45 (Official Build) nightly (64-bit)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | Windows 11 Version 21H2 (Build 22000.318)
  • ensured that each inline tipping setting can be disabled/enabled on it's own
  • ensured that multiple inline tipping settings can be disabled/disabled at the same time
  • ensured that the Relaunch button is correctly displayed
  • ensure that the Relaunch button(s) are cleared once the browser has been restarted
  • ensured that restarting the browser doesn't cause any crashes/obvious regressions/issues

Twitter:

  • ensured that the BAT icon (inline tipping) isn't being displayed when disabled via brave://settings/disabled
  • ensured that the BAT icon (inline tipping) is correctly being displayed when disabled via brave://settings/disabled
  • ensured that clicking on the BAT icon (inline tipping) correctly displays the tipping banner
GH (inline disabled GH (inline enabled GH (inline tipping banner
twitterDisabled twitterEnabled twitterTipping

GH:

  • ensured that the BAT icon (inline tipping) isn't being displayed when disabled via brave://settings/disabled
  • ensured that the BAT icon (inline tipping) is correctly being displayed when disabled via brave://settings/disabled
  • ensured that clicking on the BAT icon (inline tipping) correctly displays the tipping banner
GH (inline disabled GH (inline enabled GH (inline tipping banner
GHDisabled GHEnabled image

reddit:

  • ensured that the BAT icon (inline tipping) isn't being displayed when disabled via brave://settings/disabled
  • ensured that the BAT icon (inline tipping) is correctly being displayed when disabled via brave://settings/disabled
  • ensured that clicking on the BAT icon (inline tipping) correctly displays the tipping banner
reddit (inline disabled reddit (inline enabled reddit (inline tipping banner
redditDisabled redditEnabled redditTipping

I also found the following two issues while running through the verifications, however they're not high priority and don't block the uplift of #11180.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relaunch option is missing in brave://settings/rewards
3 participants