Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs]: We should subclass TabFeatures with a new BraveTabFeatures class to make it easier to add new features #43437

Open
fallaciousreasoning opened this issue Jan 22, 2025 · 0 comments · May be fixed by brave/brave-core#27322
Open

[Tabs]: We should subclass TabFeatures with a new BraveTabFeatures class to make it easier to add new features #43437

fallaciousreasoning opened this issue Jan 22, 2025 · 0 comments · May be fixed by brave/brave-core#27322
Assignees
@fallaciousreasoning
Labels
dev-concern

Comments

@fallaciousreasoning
Copy link

fallaciousreasoning commented Jan 22, 2025 •
edited
Loading

Upstream has changed their recommended best practices, so we shouldn't be introducing any new TabHelpers. This will make doing things the new way much simpler in Brave.

https://chromium.googlesource.com/chromium/src/+/refs/tags/128.0.6613.5/docs/chrome_browser_design_principles.md

At its most simple level:

  • New code should not introduce new TabHelpers
  • New code should (ideally) not depend on Browser
  • The new way of doing things is to add a unique_ptr<YourClass> to the TabFeatures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
dev-concern
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tabs]: Add BraveTabFeatures brave/brave-core
1 participant
@fallaciousreasoning