Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable context menu entries for Private/Tor Windows on Leo conversations #43224

Open
2 of 6 tasks
srirambv opened this issue Jan 10, 2025 · 1 comment · May be fixed by brave/brave-core#27279
Open
2 of 6 tasks

Disable context menu entries for Private/Tor Windows on Leo conversations #43224

srirambv opened this issue Jan 10, 2025 · 1 comment · May be fixed by brave/brave-core#27279
Labels
browser-ai bug OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Disable context menu entries for Private/Tor Windows on Leo conversations

Steps to reproduce

  1. Open leo in full page view
  2. Initiate a conversation and save it
  3. Right click on conversation
  4. Shows options for opening in Private/Tor tabs which is not valid

Actual result

Image

Expected result

Leo is not enabled on Private/Tor tabs so should not be shown in context menu option

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.75.156 Chromium: 132.0.6834.83 (Official Build) beta (64-bit)
Revision 036ac4040dc50d4bd49b3438e20ab90686218543
OS Windows 11 Version 23H2 (Build 22631.4602)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @petemill
@mattmcalister mattmcalister added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 20, 2025
@mattmcalister mattmcalister moved this to Important / Polish in Browser AI Jan 20, 2025
@hashmi-waseem hashmi-waseem linked a pull request Jan 20, 2025 that will close this issue
Open
24 tasks
@hashmi-waseem
Copy link

hashmi-waseem commented Jan 20, 2025 •
edited
Loading

This issue has been fixed in this pull request: brave/brave-core#27279
@mattmcalister

incognito-tor-removed-on-leo-page.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser-ai bug OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
Browser AI
Status: Important / Polish
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(leo): Remove incognito and tor options from the context menu on l… hashmi-waseem/brave-core
3 participants
@mattmcalister @srirambv @hashmi-waseem