From f27fad6914bbf3539823f3cffa67823e072ccb16 Mon Sep 17 00:00:00 2001 From: Mark Pilgrim <43750833+pilgrim-brave@users.noreply.github.com> Date: Wed, 22 Jun 2022 18:39:09 -0400 Subject: [PATCH] Disable reduce language feature by default (#13905) * Disable reduce language feature by default * enable feature for browsertest --- .../farbling/brave_navigator_languages_farbling_browsertest.cc | 2 ++ components/brave_shields/common/features.cc | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/browser/farbling/brave_navigator_languages_farbling_browsertest.cc b/browser/farbling/brave_navigator_languages_farbling_browsertest.cc index 07a0277cfbaa..ebf2c4cef789 100644 --- a/browser/farbling/brave_navigator_languages_farbling_browsertest.cc +++ b/browser/farbling/brave_navigator_languages_farbling_browsertest.cc @@ -37,6 +37,7 @@ #include "third_party/blink/renderer/core/frame/navigator_language.h" using brave_shields::ControlType; +using brave_shields::features::kBraveReduceLanguage; using content::TitleWatcher; namespace { @@ -48,6 +49,7 @@ class BraveNavigatorLanguagesFarblingBrowserTest : public InProcessBrowserTest { public: BraveNavigatorLanguagesFarblingBrowserTest() : https_server_(net::EmbeddedTestServer::TYPE_HTTPS) { + feature_list_.InitAndEnableFeature(kBraveReduceLanguage); brave::RegisterPathProvider(); base::FilePath test_data_dir; base::PathService::Get(brave::DIR_TEST_DATA, &test_data_dir); diff --git a/components/brave_shields/common/features.cc b/components/brave_shields/common/features.cc index c1d4f92723c9..2d376c9d6a2a 100644 --- a/components/brave_shields/common/features.cc +++ b/components/brave_shields/common/features.cc @@ -53,7 +53,7 @@ const base::Feature kBraveExtensionNetworkBlocking{ "BraveExtensionNetworkBlocking", base::FEATURE_DISABLED_BY_DEFAULT}; // When enabled, language headers and APIs may be altered by Brave Shields. const base::Feature kBraveReduceLanguage{"BraveReduceLanguage", - base::FEATURE_ENABLED_BY_DEFAULT}; + base::FEATURE_DISABLED_BY_DEFAULT}; // When enabled, Brave will always report Light in Fingerprinting: Strict mode const base::Feature kBraveDarkModeBlock{"BraveDarkModeBlock", base::FEATURE_ENABLED_BY_DEFAULT};