Add provider to tip compliment

Fixes brave/brave-browser#4586
brave · May 30, 2019 · a07fe59 · a07fe59
1 parent 8ad632b
commit a07fe59
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 10 deletions.
diff --git a/browser/ui/webui/brave_tip_ui.cc b/browser/ui/webui/brave_tip_ui.cc
@@ -347,7 +347,7 @@ void RewardsTipDOMHandler::OnRecurringTipSaved(
 }
 
 void RewardsTipDOMHandler::TweetTip(const base::ListValue *args) {
-  DCHECK_EQ(args->GetSize(), 2U);
+  DCHECK_EQ(args->GetSize(), 3U);
 
   if (!rewards_service_)
     return;
@@ -359,10 +359,13 @@ void RewardsTipDOMHandler::TweetTip(const base::ListValue *args) {
   std::string tweet_id;
   if (!args->GetString(1, &tweet_id))
     return;
+  std::string provider;
+  if (!args->GetString(2, &provider))
+     return;
 
   // Share the tip comment/compliment on Twitter.
   std::string comment = l10n_util::GetStringFUTF8(
-      IDS_BRAVE_REWARDS_LOCAL_COMPLIMENT_TWEET, base::UTF8ToUTF16(name));
+      IDS_BRAVE_REWARDS_LOCAL_COMPLIMENT_TWEET, base::UTF8ToUTF16(name), base::UTF8ToUTF16(provider));
   std::string hashtag = l10n_util::GetStringUTF8(
       IDS_BRAVE_REWARDS_LOCAL_COMPLIMENT_TWEET_HASHTAG);
   std::map<std::string, std::string> share_url_args;

diff --git a/components/brave_rewards/resources/tip/actions/tip_actions.ts b/components/brave_rewards/resources/tip/actions/tip_actions.ts
@@ -9,9 +9,10 @@ import { types } from '../constants/tip_types'
 
 export const onCloseDialog = () => action(types.ON_CLOSE_DIALOG)
 
-export const onTweet = (name: string, tweetId: string) => action(types.ON_TWEET, {
+export const onTweet = (name: string, tweetId: string, provider: string) => action(types.ON_TWEET, {
   name,
-  tweetId
+  tweetId,
+  provider
 })
 
 export const onPublisherBanner = (data: RewardsTip.Publisher) => action(types.ON_PUBLISHER_BANNER, {

diff --git a/components/brave_rewards/resources/tip/components/tipSite.tsx b/components/brave_rewards/resources/tip/components/tipSite.tsx
@@ -25,14 +25,14 @@ class TipSite extends React.Component<Props, {}> {
 
   onTweet = () => {
     let name = this.props.publisher.name
-    if (this.props.publisher.provider === 'twitter') {
+    let provider = this.props.publisher.provider
+    if (provider === 'twitter') {
       const url = this.props.url
       if (url && url.length > 0) {
         name = `@${url.replace(/^.*\/(.*)$/, '$1')}`
       }
     }
-
-    this.actions.onTweet(name, '')
+    this.actions.onTweet(name, '', provider)
     this.actions.onCloseDialog()
   }
 

diff --git a/components/brave_rewards/resources/tip/reducers/tip_reducer.ts b/components/brave_rewards/resources/tip/reducers/tip_reducer.ts
@@ -24,7 +24,6 @@ export const defaultState: RewardsTip.State = {
 
 const publishersReducer: Reducer<RewardsTip.State> = (state: RewardsTip.State = defaultState, action) => {
   const payload = action.payload
-
   switch (action.type) {
     case types.ON_CLOSE_DIALOG:
       state = { ...state }
@@ -34,7 +33,8 @@ const publishersReducer: Reducer<RewardsTip.State> = (state: RewardsTip.State =
     case types.ON_TWEET:
       chrome.send('brave_rewards_tip.tweetTip', [
         payload.name,
-        payload.tweetId
+        payload.tweetId,
+        payload.provider
       ])
       break
     case types.ON_PUBLISHER_BANNER: {

diff --git a/components/resources/brave_components_strings.grd b/components/resources/brave_components_strings.grd
@@ -260,7 +260,7 @@
       <message name="IDS_BRAVE_REWARDS_LOCAL_GRANT_ALREADY_CLAIMED_TEXT" desc="">Sorry, it appears that this grant has already been claimed.</message>
       <message name="IDS_BRAVE_REWARDS_LOCAL_DONAT_NEXT_DATE" desc="Description of the date in the donation box">Next monthly tip date</message>
       <message name="IDS_BRAVE_REWARDS_LOCAL_COMPLIMENT_TWEET" desc="">
-        I just tipped <ph name="NAME">$1<ex>user</ex></ph> using the Brave Browser. Check it out at https://brave.com/tips.
+        I just tipped <ph name="NAME">$1<ex>user</ex></ph> on <ph name="PROVIDER">$2<ex>site</ex></ph> using the Brave Browser. Check it out at https://brave.com/tips.
       </message>
       <message name="IDS_BRAVE_REWARDS_LOCAL_COMPLIMENT_TWEET_HASHTAG" desc="">TipWithBrave</message>