Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README and support email #1718

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Update README and support email #1718

merged 1 commit into from
Oct 18, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 18, 2018

Fix #1702

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bbondy bbondy self-assigned this Oct 18, 2018
@bbondy bbondy requested a review from bsclifton October 18, 2018 20:42
bsclifton
bsclifton approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ brought tears to my eyes 😭 Beautiful

@bsclifton bsclifton merged commit ce363d2 into master Oct 18, 2018
@bsclifton bsclifton deleted the readme branch October 18, 2018 20:48
@bbondy bbondy removed the 0.58.x label Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.58.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@bbondy @bsclifton