[Desktop] Address bar background color does not change in private mode when dark theme is enabled

[georapbox]

Description

When dark theme is enabled, if I open a Private window, the address bar background color remains the same as in normal window. If light theme is enabled, the address bar background color changes to adjust to the purple theme of the Private window.

Steps to Reproduce

1. Enable dark theme from Settings > Appearance > Brave colors
2. Open a new Private window (File > New Private Window)

Actual result:

The address bar background color is the same with the one of the dark theme, not adjusting to the purple theme of the private window.

Expected result:

The address bar background color should change to adjust to the purple theme of the private window.

Reproduces how often:

Always

Brave version (brave://version info)

Brave: 1.9.72 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision: 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS: macOS Version 10.15.1

Version/Channel Information:

• Can you reproduce this issue with the current release?
  Yes
• Can you reproduce this issue with the beta channel?
  Yes
• Can you reproduce this issue with the dev channel?
  Yes
• Can you reproduce this issue with the nightly channel?
  Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
  Not related to Brave Shields
• Does the issue resolve itself when disabling Brave Rewards?
  Not related to Brave Rewqrds
• Is the issue reproducible on the latest version of Chrome?
  No

Miscellaneous Information:

[bsclifton]

I'm not able to reproduce this on Windows - @georapbox do you have the mouse in the URL bar? If the URL bar is hovered, it will change to that color

[simonhong]

I think the issue is address bar background is not refreshed if address bar doesn't have focus while changing theme.

@karenkliu , we are using different address bar bg colors for light/dark theme like captured below.
Is this correct? or we should use same color regardless of dark/light theme?

[georapbox]

Unfortunately I don't have a Windows machine available at the moment to test. The issue appears to be on MacOS though. The address bar background color does not adjust to the purple theme of the private window. Below I attach a screenshot comparing light and dark theme along with how the address bar reacts on mouse away, mouse over and focus states. Hope this proves helpful..

[bsclifton]

@georapbox this is perfect, thanks! So without mouse above, it's black rather than purple. Can see problem clearly now

[karenkliu]

@georapbox Thanks for the screenshot!

@simonhong In private/Tor mode we use the same colors in light and dark theme. As you can see from the above screenshot, in dark theme the address bar background should not be dark grey - it should be purple, the same as light theme.

[360fun]

I've a similar problem: when the dark theme/mode is active I can barely see the dark blue text/urls in the address bar.

The color contrast is very very low (dark blue on almost black backgrounf), even for a "normal" person: for people with problems it probably looks all background with no urls.

[karenkliu]

☝️ Changing Chromium colored address bar links to Brave-styled in light/dark should probably be logged as a separate issue.

[GeetaSarvadnya]

Verification passed on

Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Reproduced issue in 1.11.x
Dark theme - PT address bar

• Verified the test plan from Use same location/omnibox color in light/dark mode with private brave-core#5899
• Verified that Private window always uses the same color for the address bar in 1.12.x
• Encountered [Desktop] Bookmarks bar on NTP is not visible for custom theme Sea Foam in PT and TOR tabs #10927

PT window Light theme

PT window Dark theme

Custom theme - PT window light theme

Custom theme - PT window dark theme

Verification passed on

Brave	1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision	a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS	Ubuntu 18.04 LTS

Reproduced issue in 1.11.x
Dark theme - PT address bar

• Verified the test plan from Use same location/omnibox color in light/dark mode with private brave-core#5899
• Verified that Private window always uses the same color for the address bar in 1.12.x

PT window Light theme

PT window Dark theme

---

Verified passed with

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

• Reproduced the issue on 1.11.x:

• Verified test plan from Use same location/omnibox color in light/dark mode with private brave-core#5899

Dark theme private window:

Light theme private window: