Country not part of ad confirmation call - follow up to #8100

[LaurenWags]

Description

Found while testing #8100

Per above issue, countryCode should be present (if country is large enough) on release builds for ad confirmations.

Steps to Reproduce

1. Install 1.9.70 w/ flags(I used --enable-logging=stderr --vmodule=brave_ads=3 --log-level=2) and be running Charles
2. Enable Rewards
3. Trigger an ad

Actual result:

build channel and platform are listed, but not countryCode:

[15741:775:0518/084541.203144:INFO:redeem_token.cc(108)] CreateConfirmation
[15741:775:0518/084541.203173:INFO:redeem_token.cc(110)] POST /v1/confirmation/{confirmation_id}/{credential}
[15741:775:0518/084541.203189:INFO:redeem_token.cc(113)] URL Request:
[15741:775:0518/084541.203208:INFO:redeem_token.cc(116)]   URL: https://ads-serve.brave.com/v1/confirmation/9330bfb8-0186-4884-864c-4aedf1cd4cab/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiMXFBR1FWMXoyZSt2U2VRR0NjUTdOQk5WaTk3enJkRkhMc1loWHJzRXVudz1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCI4NGViMjc4NS05ZGViLTRhMmEtYTFjYS1mZjZjMjU3NzY4NWVcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJtYWNvc1wiLFwidHlwZVwiOlwiZGlzbWlzc1wifSIsInNpZ25hdHVyZSI6IlRCN0FucEdyT09UYk5NcFBjUUdvblNWT01xRVZuWG1wTFBxRVZKUkg5R0V0TW5vUWx2MDJQNmtSQ2V4Z2R6elJacUZEcWY1cUR3dkJUMllZbFRUeHFRPT0iLCJ0IjoiWjkrU1ZvMTU2OWE2ekdrSU9JMUdPVXBDWFFmUWVCVTB5MDJEU29FRkJNRWx5Zmk5OTJXNnJmTmx2YkVucU16TEZPeUJBZWhmZlJoUkF2WVB5bUg5Y3c9PSJ9
[15741:775:0518/084541.203456:INFO:redeem_token.cc(128)]   Body: {"blindedPaymentToken":"1qAGQV1z2e+vSeQGCcQ7NBNVi97zrdFHLsYhXrsEunw=","buildChannel":"release","creativeInstanceId":"84eb2785-9deb-4a2a-a1ca-ff6c2577685e","payload":{},"platform":"macos","type":"dismiss"}

Expected result:

Since 1.9.70 is on Release channel and my region = US in my OS settings, I should have countryCode in the above, but it is not there.

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

• Can you reproduce this issue with the current release? 1.8.x n/a, but yes for 1.9.x release preview versions
• Can you reproduce this issue with the beta channel? not applicable - should only show for release builds
• Can you reproduce this issue with the dev channel? not applicable - should only show for release builds
• Can you reproduce this issue with the nightly channel? not applicable - should only show for release builds

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @tmancey @jsecretan @rebron @brave/legacy_qa

[btlechowski]

Marked it as QA/Blocked till we get a release build.

[LaurenWags]

Removing QA/Blocked since https://github.com/brave/brave-browser/releases/tag/v1.11.94 is available

[LaurenWags]

Verification in progress (pending question)

Brave	1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
Revision	e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS	macOS Version 10.14.6 (Build 18G3020)

• Verified STR from description
• Confirmed buildChannel and platform are still present.
• Spot checked countries to be included as per Send platform, build channel, and country as part of ad confirmation calls where it meets privacy standards  #8100 (comment). Confirmed for US (United States), NZ (New Zealand), and BE (Belgium) which are in the list from Send platform, build channel, and country as part of ad confirmation calls where it meets privacy standards  #8100.

Screenshots where countryCode is included

countryCode = US (United States)

countryCode = NZ (New Zealand)

countryCode = BE (Belgium)

• Confirmed a couple countries which are not included in the list in Send platform, build channel, and country as part of ad confirmation calls where it meets privacy standards  #8100 do not send country code. Ex: AW (Aruba), MC (Monaco) which are not in the large country list from Send platform, build channel, and country as part of ad confirmation calls where it meets privacy standards  #8100.

Screenshots where countryCode is not included

countryCode = AW (Aruba)

countryCode = MC (Monaco)

• Confirmed a couple countries which are not included in the list in Send platform, build channel, and country as part of ad confirmation calls where it meets privacy standards  #8100 send countryCode as ??. Ex: AS (American Samoa), MF (St Martin) which are not in the large country list from Send platform, build channel, and country as part of ad confirmation calls where it meets privacy standards  #8100.

Screenshots where countryCode is sent as ??

countryCode = AS (American Samoa)

countryCode = MF (St Martin)

• Encountered and logged [Desktop] onCreateConfirmation and onFetchPaymentToken fail for countries that send ?? for countryCode - follow up to 9823 #10710 while testing

---

Verification passed on

Brave	1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
Revision	e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS	Ubuntu 18.04 LTS

• Verified STR from description
• Confirmed buildChannel and platform are still present.
• Spot checked countries to be included as per Send platform, build channel, and country as part of ad confirmation calls where it meets privacy standards  #8100 (comment). Confirmed for US (United States), PL (Poland), and DE (Germany) which are in the list from Send platform, build channel, and country as part of ad confirmation calls where it meets privacy standards  #8100.

Screenshots where countryCode is included

countryCode = US (United States)

countryCode = PL (Poland)

countryCode = DE (Germany)

Verification passed on

Brave | 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
-- | --
Revision | e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS | Windows 10 OS Version 1903 (Build 18362.900)

• Verified STR from description
• Confirmed buildChannel and platform are still present.
• Spot checked countries to be included as per Send platform, build channel, and country as part of ad confirmation calls where it meets privacy standards  #8100 (comment). Confirmed for US (United States), FR (France), and AU (Australia) which are in the list from Send platform, build channel, and country as part of ad confirmation calls where it meets privacy standards  #8100.

US

FR

Content: {"blindedPaymentToken":"EHqQFUKE26rg0PF8v2576wHq2cEFJxlU3DjeYXC8bEI=","buildChannel":"release","countryCode":"FR","creativeInstanceId":"caceaac0-e62c-4ce6-b2ad-291957c70124","payload":{},"platform":"windows","type":"view"}

AU

Content: {"blindedPaymentToken":"knzbslPTT3DjW4WmyZ1vXjmTZ1BX6YEjsoi6Q01xlzo=","buildChannel":"release","countryCode":"AU","creativeInstanceId":"8068b0b9-394a-426d-84ef-d333b7773e4f","payload":{},"platform":"windows","type":"view"}