Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be able to specify a specific version with Windows stub installer #976

Closed
simonhong opened this issue Sep 6, 2018 · 6 comments · Fixed by brave/brave-core#722
Closed

Be able to specify a specific version with Windows stub installer #976

simonhong opened this issue Sep 6, 2018 · 6 comments · Fixed by brave/brave-core#722
Assignees
@simonhong
Labels
installer/omaha Issues for windows omaha installer OS/Windows QA/No release-notes/exclude setup/installer
Milestone
0.56.x - Release ...

Comments

@simonhong
Copy link
Member

Current stub installer always tries to install latest version in update server.
@RyanJarv
Copy link
Contributor

RyanJarv commented Sep 6, 2018

This would be useful for testing updates

@bbondy
Copy link
Member

bbondy commented Sep 9, 2018

I think this might be preferable, maybe add a command line arg if one doesn't already exist to download a specific version?

@bbondy bbondy added this to the Triage Backlog milestone Sep 9, 2018
@RyanJarv
Copy link
Contributor

Fairly certain this is supported somehow, may be worth looking into what the chromium QA process is if it's documented anywhere.

@bsclifton
Copy link
Member

For anyone wanting to check this out, src/chrome/installer/mini_installer/mini_installer.cc is a good place to start 😄

@bsclifton bsclifton changed the title Set specific version to windows stub installer Be able to specify a specific version with Windows stub installer Sep 28, 2018
@bbondy bbondy modified the milestones: 2.x Backlog, 1.x Backlog Sep 30, 2018
@simonhong simonhong self-assigned this Oct 21, 2018
@simonhong
Copy link
Member Author

I'll close this issue when we can build omaha standalone installer from brave-core (#1784) because we can install specific brave version with standalone installer.

@simonhong simonhong added the installer/omaha Issues for windows omaha installer label Oct 23, 2018
@simonhong simonhong mentioned this issue Oct 26, 2018
Merged
18 tasks
@bbondy bbondy modified the milestones: 1.x Backlog, 0.56.x - Beta Oct 30, 2018
@bbondy
Copy link
Member

bbondy commented Oct 30, 2018

Updated label to 0.56.x since the associated PR was merged there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
installer/omaha Issues for windows omaha installer OS/Windows QA/No release-notes/exclude setup/installer
Projects
None yet
Milestone
0.56.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Integrate omaha build into brave-core brave/brave-core
5 participants
@bbondy @kjozwiak @RyanJarv @bsclifton @simonhong