Use Greaselion for YouTube publishers #9133

NejcZdovc · 2020-04-10T10:09:38Z

we should switch to GL for YT so that we can have faster turn around rate when something breaks.

LaurenWags · 2020-09-28T14:57:41Z

Verification passed using below builds

Brave	1.16.42 Chromium: 86.0.4240.55 (Official Build) nightly (x86_64)
Revision	a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS	macOS Version 10.14.6 (Build 18G3020)

General

Confirmed Greaselion script no longer needs to be installed manually, just need to confirm that Brave Local Data Updater is version >=1.0.27.

Confirmed visiting non-verified publishers showed the generic YT favicon in panel and AC table. Visited each of the below using a clean profile:

Channel URL

Verified steps from Rewards GreaseLion - YouTube brave-core#5440, used staging env
Verified publisher:
- Confirmed tip to https://www.youtube.com/channel/UCD7siefto4I33L4U61IU5LQ showed on Tips panel of brave://rewards as expected
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
Non-verified publisher:
- Confirmed tip to https://www.youtube.com/channel/UCIEv3lZ_tNXHzL3ox-_uUGQ showed on pending table
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
Custom banner:
- Visited https://www.youtube.com/channel/UCCs7AQEDwrHEc86r0NNXE_A (on staging), confirmed custom banner was displayed

User URL

Logged [Desktop] generic YT favicon displayed for verified creator in certain cases #11883 for favicon
Logged [Desktop] sometimes the publisher name isn't shown on the panel only "on Youtube" is shown #11888 for intermittent missing publisher name
Verified steps from Rewards GreaseLion - YouTube brave-core#5440, used staging env
Verified publisher:
- Confirmed tip to https://www.youtube.com/user/JJDSampson showed on Tips panel of brave://rewards as expected
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
Non-verified publisher:
- Confirmed tip to https://www.youtube.com/user/gordonramsay showed on pending table
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
Custom banner (used prod env)
- Visited https://www.youtube.com/user/JJDSampson w/ prod env, confirmed custom banner was displayed

Activity

Logged #11931, #11932 as an intermittent issue observed where the AC list isn't always as expected for video activity.

Also encountered #11933 for AC list not populating as expected when opening YT videos via right click.

Ran thru steps from brave/brave-core#5440, substituted a shorter video (https://www.youtube.com/watch?v=XoxrQr-w8Kg). Video length was 1min 33s or 93s which matches the duration in the DB.

Brave	1.16.45 Chromium: 86.0.4240.55 (Official Build) nightly (x86_64)
Revision	a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS	macOS Version 10.14.6 (Build 18G3020)

Video URL

Verified publisher (using staging env):
- Confirmed tip to https://www.youtube.com/watch?v=uWKCm2GKVyE showed on Tips page of brave://rewards as expected
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
- Watched a video for a bit and
  - Confirmed panel showed expected favicon and %
  - Confirmed showed on AC table and % value was as expected
Non-verified publisher (using staging env):
- Confirmed tip to https://www.youtube.com/watch?v=9i4SKHbhbqk showed on pending table
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Watched a video for a bit and
  - Confirmed panel showed expected favicon and %
  - Confirmed showed on AC table and % value was as expected
Custom banner (using prod env)
- Visited https://www.youtube.com/watch?v=uWKCm2GKVyE with prod env and confirmed custom tipping banner was shown

Brave	1.16.46 Chromium: 86.0.4240.55 (Official Build) nightly (x86_64)
Revision	a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS	macOS Version 10.14.6 (Build 18G3020)

Custom URL

Verified publisher (using production env):
- Confirmed tip to https://www.youtube.com/vice showed on Tips page of brave://rewards as expected
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
Non-verified publisher (using production env):
- Confirmed tip to https://www.youtube.com/ninja showed on pending table
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
Custom banner (using prod env) - note, I was unable to find a verified YT publisher with a custom URL and a fully customized banner similar to examples above. However, in the example below the banner text was customized and is different from the default text.
- Visited https://www.youtube.com/firstwefeast with prod env and confirmed custom tipping banner was shown

History

Verified steps from Rewards GreaseLion - YouTube brave-core#5440
Confirmed after navigating to various youtube URLs in the same tab the panel displayed the expected publisher info. Used a mix of verified and non-verified publishers
Used backward/forward navigation in the same tab and confirmed the panel showed the expected publisher info.

Tab Activation

Verified steps from Rewards GreaseLion - YouTube brave-core#5440
Opened various YT URLs in multiples tabs and confirmed the panel displayed the expected publisher info. Used a mix of verified and non-verified publishers
Switched between the various tabs and confirmed the panel showed the expected publisher info.

Tipping non-YouTube publishers

Verified steps from Rewards GreaseLion - YouTube brave-core#5440
Confirmed able to tip each of the following other types of verified publishers: regular sites, GitHub, Twitch, Reddit, Twitter. Vimeo panel is currently broken (Rewards panel doesn't show creator specific information for Vimeo #11840) and there are various known issues (especially with Twitch) which will be addressed as each item is implemented via Greaselion.
Checked one time and recurring tipping for the various publisher types listed above

Regular site:

GitHub:

Twitch:

Vimeo (broken):

Reddit:

Twitter:

One time and recurring tips:

Other Various Tests - Monthly Contributions

Set up monthly tips for each of the following types of verified publishers: YouTube, regular sites, GitHub, Reddit, Twitter, Twitch. Confirmed at expected time the monthly contributions were made:

Other Various Tests - panel and banner messaging

Confirmed non-verified YT publishers show specific messaging on panel and tipping banners

Confirmed verified, non KYC'd YT publishers show different messaging on panel and tipping banners

Confirmed verified, KYC'd YT publishers do not show any messaging on panel and tipping banners

Other Various Tests - Settings

Modified AC settings to disable "Allow contribution to videos". Viewed some YT videos for several minutes each. Confirmed no YT videos were added to AC table.
Re-enabled "Allow contribution to videos" and visited a new YT video. Confirmed the publisher was added to AC list.
Confirmed able to exclude a YT publisher from AC via the toggle on the panel
Confirmed able to exclude a YT publisher from AC via the AC list on brave://rewards
Confirmed able to exclude a YT publisher from AC via the popup list of AC sites from brave://rewards
Confirmed able to remove a YT publisher from the exclude list and have the publisher get re-added to AC

Brave	1.16.47 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
Revision	a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS	macOS Version 10.14.6 (Build 18G3020)

Upgrade

Using 1.15.65 (last 1.15.x Dev version), set up the following data:

Have a few 1 time tips to verified publishers completed (some to YT publishers, some other publisher types also)
Have a few pending 1 time tips to non-verified YT publishers
Have a few recurring tips to verified publishers completed (some to YT publishers, some other publisher types also)
Have AC list populated with a mix of verified and non-verified sites, a mix of publisher types including YT publishers

Upgrade to 1.16.x (on Dev channel) version with Greaselion YT tipping.

Confirm all data is preserved as expected on brave://rewards.
Confirm if you navigate to the various publishers and open the panel, the AC % is preserved (if publisher is part of AC list), the recurring tip amount is preserved (if set up). Confirm panel shows expected information (favicon if applicable, publisher name, etc). Confirm custom tip banner is available (if applicable)
Confirm if you view another video by a publisher already on AC list the values in the DB (I looked at duration/visits on activity_info) and AC % change appropriately
Confirm you can view a YT video by a publisher not already on AC list and it gets added to AC list
For an existing recurring tip, confirm you are able to adjust the recurring tip amount for YT publisher from the panel
For an existing recurring tip, confirm you are able to delete a recurring tip for YT publisher

Verification passed on

Brave	1.16.55 Chromium: 86.0.4240.72 (Official Build) dev (64-bit)
Revision	581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134}
OS	Ubuntu 18.04 LTS

General

Confirmed Greaselion script no longer needs to be installed manually, just need to confirm that Brave Local Data Updater is version >=1.0.27.

Confirmed visiting non-verified publishers showed the generic YT favicon in panel and AC table. Visited each of the below using a clean profile:
- https://www.youtube.com/c/SpaceVideosHD
- https://www.youtube.com/watch?v=9i4SKHbhbqk

Channel URL

Verified steps from Rewards GreaseLion - YouTube brave-core#5440, used staging env
Verified publisher:
- Confirmed tip to https://www.youtube.com/channel/UCD7siefto4I33L4U61IU5LQ showed on Tips panel of brave://rewards as expected
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
Non-verified publisher:
- Confirmed tip to https://www.youtube.com/channel/UCIEv3lZ_tNXHzL3ox-_uUGQ showed on pending table
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
Custom banner:
- Visited https://www.youtube.com/channel/UCCs7AQEDwrHEc86r0NNXE_A (on staging), confirmed custom banner was displayed

User URL

Verified steps from Rewards GreaseLion - YouTube brave-core#5440, used staging env
Verified publisher:
- Confirmed tip to https://www.youtube.com/user/JJDSampson showed on Tips panel of brave://rewards as expected
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
Non-verified publisher:
- Confirmed tip to https://www.youtube.com/user/gordonramsay showed on pending table
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
Custom banner (used prod env)
- Visited https://www.youtube.com/user/JJDSampson w/ prod env, confirmed custom banner was displayed

Activity

Encountered #11931, #11932 as an intermittent issue observed where the AC list isn't always as expected for video activity.

Also encountered #11933 for AC list not populating as expected when opening YT videos via right click.

Ran thru steps from brave/brave-core#5440, substituted a shorter video (https://www.youtube.com/watch?v=XoxrQr-w8Kg). Video length was 1min 33s or 93s which matches the duration in the DB.

Video URL

Verified publisher (using staging env):
- Confirmed tip to https://www.youtube.com/watch?v=uWKCm2GKVyE showed on Tips page of brave://rewards as expected
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
- Watched a video for a bit and
  - Confirmed panel showed expected favicon and %
  - Confirmed showed on AC table and % value was as expected
Non-verified publisher (using staging env):
- Confirmed tip to https://www.youtube.com/watch?v=9i4SKHbhbqk showed on pending table
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Watched a video for a bit and
  - Confirmed panel showed expected favicon and %
  - Confirmed showed on AC table and % value was as expected
Custom banner (using prod env)
- Visited https://www.youtube.com/watch?v=uWKCm2GKVyE with prod env and confirmed custom tipping banner was shown

Custom URL

Verified publisher (using production env):
- Confirmed tip to https://www.youtube.com/vice showed on Tips page of brave://rewards as expected
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
Non-verified publisher (using production env):
- Confirmed tip to https://www.youtube.com/ninja showed on pending table
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
Custom banner (using prod env) - note, I was unable to find a verified YT publisher with a custom URL and a fully customized banner similar to examples above. However, in the example below the banner text was customized and is different from the default text.
- Visited https://www.youtube.com/firstwefeast with prod env and confirmed custom tipping banner was shown

History

Verified steps from Rewards GreaseLion - YouTube brave-core#5440
Confirmed after navigating to various youtube URLs in the same tab the panel displayed the expected publisher info. Used a mix of verified and non-verified publishers
Used backward/forward navigation in the same tab and confirmed the panel showed the expected publisher info.

Tab Activation

Verified steps from Rewards GreaseLion - YouTube brave-core#5440
Opened various YT URLs in multiples tabs and confirmed the panel displayed the expected publisher info. Used a mix of verified and non-verified publishers
Switched between the various tabs and confirmed the panel showed the expected publisher info.

Tipping non-YouTube publishers

Verified steps from Rewards GreaseLion - YouTube brave-core#5440
Confirmed able to tip each of the following other types of verified publishers: regular sites, GitHub, Twitch, Reddit, Twitter. Vimeo panel is currently broken (Rewards panel doesn't show creator specific information for Vimeo #11840) and there are various known issues (especially with Twitch) which will be addressed as each item is implemented via Greaselion.
Checked one time and recurring tipping for the various publisher types listed above

Regular site:

GitHub:

Twitch:

Encountered #6142

Vimeo (broken):

Reddit:

Twitter:

One time and recurring tips:

Other Various Tests - Monthly Contributions

Set up monthly tips for each of the following types of verified publishers. Confirmed at expected time the monthly contributions were made:

Other Various Tests - panel and banner messaging

Confirmed non-verified YT publishers show specific messaging on panel and tipping banners
Confirmed verified, non KYC'd YT publishers show different messaging on panel and tipping banners
Confirmed verified, KYC'd YT publishers do not show any messaging on panel and tipping banners

Other Various Tests - Settings

Modified AC settings to disable "Allow contribution to videos". Viewed some YT videos for several minutes each. Confirmed no YT videos were added to AC table.
Re-enabled "Allow contribution to videos" and visited a new YT video. Confirmed the publisher was added to AC list.
Confirmed able to exclude a YT publisher from AC via the toggle on the panel
Confirmed able to exclude a YT publisher from AC via the AC list on brave://rewards
Confirmed able to exclude a YT publisher from AC via the popup list of AC sites from brave://rewards
Confirmed able to remove a YT publisher from the exclude list and have the publisher get re-added to AC

Upgrade

Using 1.15.x , set up the following data:

Have a few 1 time tips to verified publishers completed (some to YT publishers, some other publisher types also)
Have a few pending 1 time tips to non-verified YT publishers
Have a few recurring tips to verified publishers completed (some to YT publishers, some other publisher types also)
Have AC list populated with a mix of verified and non-verified sites, a mix of publisher types including YT publishers

Upgrade to 1.16.x version with Greaselion YT tipping.

Confirm all data is preserved as expected on brave://rewards.
Confirm if you navigate to the various publishers and open the panel, the AC % is preserved (if publisher is part of AC list), the recurring tip amount is preserved (if set up). Confirm panel shows expected information (favicon if applicable, publisher name, etc). Confirm custom tip banner is available (if applicable)
Confirm if you view another video by a publisher already on AC list the values in the DB (I looked at duration/visits on activity_info) and AC % change appropriately
Confirm you can view a YT video by a publisher not already on AC list and it gets added to AC list
For an existing recurring tip, confirm you are able to adjust the recurring tip amount for YT publisher from the panel
For an existing recurring tip, confirm you are able to delete a recurring tip for YT publisher

Verification passed using


Brave | 1.16.51 Chromium: 86.0.4240.68 (Official Build) dev (64-bit)
-- | --
Revision | ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

General

Confirmed Greaselion script no longer needs to be installed manually, just need to confirm that Brave Local Data Updater is version >=1.0.28

Confirmed visiting non-verified publishers showed the generic YT favicon in panel and AC table. Visited each of the below using a clean profile:


Brave | 1.16.61 Chromium: 86.0.4240.80 (Official Build) dev (64-bit)
-- | --
Revision | 7ed88b53bda45a2d19efb4f8706dd6b6cad0d3af-refs/branch-heads/4240@{#1183}
OS | Windows 10 OS Version 1903 (Build 18362.1082)

Channel URL

Verified steps from Rewards GreaseLion - YouTube brave-core#5440, used staging env
Verified publisher:
- Confirmed tip to https://www.youtube.com/channel/UCD7siefto4I33L4U61IU5LQ showed on Tips panel of brave://rewards as expected
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
Non-verified publisher:
- Confirmed tip to https://www.youtube.com/channel/UCIEv3lZ_tNXHzL3ox-_uUGQ showed on pending table
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
Custom banner:
- Visited https://www.youtube.com/channel/UCCs7AQEDwrHEc86r0NNXE_A (on staging), confirmed custom banner was displayed

User URL

Verified steps from Rewards GreaseLion - YouTube brave-core#5440, used staging env
Verified publisher:
- Confirmed tip to https://www.youtube.com/user/JJDSampson showed on Tips panel of brave://rewards as expected
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
Non-verified publisher:
- Confirmed tip to https://www.youtube.com/user/gordonramsay showed on pending table
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
Custom banner (used prod env)
- Visited https://www.youtube.com/user/JJDSampson w/ prod env, confirmed custom banner was displayed

Activity

Encountered #11931, #11932 as an intermittent issue observed where the AC list isn't always as expected for video activity.

Also encountered #11933 for AC list not populating as expected when opening YT videos via right click.

Ran thru steps from brave/brave-core#5440, substituted a shorter video (https://www.youtube.com/watch?v=XoxrQr-w8Kg). Video length was 1min 33s or 93s which matches the duration in the DB.

Video URL

Verified publisher (using staging env):
- Confirmed tip to https://www.youtube.com/watch?v=uWKCm2GKVyE showed on Tips page of brave://rewards as expected
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
- Watched a video for a bit and
  - Confirmed panel showed expected favicon and %
  - Confirmed showed on AC table and % value was as expected
Non-verified publisher (using staging env):
- Confirmed tip to https://www.youtube.com/watch?v=9i4SKHbhbqk showed on pending table
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Watched a video for a bit and
  - Confirmed panel showed expected favicon and %
  - Confirmed showed on AC table and % value was as expected
Custom banner (using prod env)
- Visited https://www.youtube.com/watch?v=uWKCm2GKVyE with prod env and confirmed custom tipping banner was shown

Custom URL

Verified publisher (using production env):
- Confirmed tip to https://www.youtube.com/vice showed on Tips page of brave://rewards as expected
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
- Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
Non-verified publisher (using production env):
- Confirmed tip to https://www.youtube.com/ninja showed on pending table
- Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
- Confirmed able to adjust monthly contribution amount from panel
- Confirmed able to remove monthly contribution from panel and brave://rewards page
Custom banner (using prod env) - note, I was unable to find a verified YT publisher with a custom URL and a fully customized banner similar to examples above. However, in the example below the banner text was customized and is different from the default text.
- Visited https://www.youtube.com/firstwefeast with prod env and confirmed custom tipping banner was shown

History

Verified steps from Rewards GreaseLion - YouTube brave-core#5440
Confirmed after navigating to various youtube URLs in the same tab the panel displayed the expected publisher info. Used a mix of verified and non-verified publishers
Used backward/forward navigation in the same tab and confirmed the panel showed the expected publisher info.

Tab Activation

Verified steps from Rewards GreaseLion - YouTube brave-core#5440
Opened various YT URLs in multiples tabs and confirmed the panel displayed the expected publisher info. Used a mix of verified and non-verified publishers
Switched between the various tabs and confirmed the panel showed the expected publisher info.

Tipping non-YouTube publishers

Verified steps from Rewards GreaseLion - YouTube brave-core#5440
Confirmed able to tip each of the following other types of verified publishers: regular sites, GitHub, Twitch, Reddit, Twitter. Vimeo panel is currently broken (Rewards panel doesn't show creator specific information for Vimeo #11840) and there are various known issues (especially with Twitch) which will be addressed as each item is implemented via Greaselion.
Checked one time and recurring tipping for the various publisher types listed above

Regular site:

GitHub:

Twitch:

Encountered #6142

Vimeo (broken):

Reddit:

Twitter:

One time and recurring tips:

Other Various Tests - Monthly Contributions

Set up monthly tips for each of the following types of verified publishers. Confirmed at expected time the monthly contributions were made:

Other Various Tests - panel and banner messaging

Confirmed non-verified YT publishers show specific messaging on panel and tipping banners
Confirmed verified, non KYC'd YT publishers show different messaging on panel and tipping banners
Confirmed verified, KYC'd YT publishers do not show any messaging on panel and tipping banners

Other Various Tests - Settings

Modified AC settings to disable "Allow contribution to videos". Viewed some YT videos for several minutes each. Confirmed no YT videos were added to AC table.
Re-enabled "Allow contribution to videos" and visited a new YT video. Confirmed the publisher was added to AC list.
Confirmed able to exclude a YT publisher from AC via the toggle on the panel
Confirmed able to exclude a YT publisher from AC via the AC list on brave://rewards
Confirmed able to exclude a YT publisher from AC via the popup list of AC sites from brave://rewards
Confirmed able to remove a YT publisher from the exclude list and have the publisher get re-added to AC

Upgrade

Using 1.15.x , set up the following data:

Have a few 1 time tips to verified publishers completed (some to YT publishers, some other publisher types also)
Have a few pending 1 time tips to non-verified YT publishers
Have a few recurring tips to verified publishers completed (some to YT publishers, some other publisher types also)
Have AC list populated with a mix of verified and non-verified sites, a mix of publisher types including YT publishers

Upgrade to 1.16.x version with Greaselion YT tipping.

Confirm all data is preserved as expected on brave://rewards.
Confirm if you navigate to the various publishers and open the panel, the AC % is preserved (if publisher is part of AC list), the recurring tip amount is preserved (if set up). Confirm panel shows expected information (favicon if applicable, publisher name, etc). Confirm custom tip banner is available (if applicable)
Confirm if you view another video by a publisher already on AC list the values in the DB (I looked at duration/visits on activity_info) and AC % change appropriately
Confirm you can view a YT video by a publisher not already on AC list and it gets added to AC list
For an existing recurring tip, confirm you are able to adjust the recurring tip amount for YT publisher from the panel
For an existing recurring tip, confirm you are able to delete a recurring tip for YT publisher

NejcZdovc added the feature/rewards label Apr 10, 2020

NejcZdovc assigned emerick Apr 10, 2020

NejcZdovc mentioned this issue Apr 10, 2020

Remove HasSameDomainAndPath from bat_helper #7153

Closed

emerick mentioned this issue May 1, 2020

Rewards GreaseLion - YouTube brave/brave-core#5440

Merged

32 tasks

emerick added the QA/Yes label Aug 3, 2020

NejcZdovc mentioned this issue Aug 27, 2020

Rewards Everywhere phase 1 #9130

Closed

15 tasks

NejcZdovc changed the title ~~Use greaselion for publisher flows~~ Use GreaseLion for YouTube publishers Aug 27, 2020

NejcZdovc added this to the 1.15.x - Nightly milestone Aug 27, 2020

NejcZdovc added release-notes/include OS/Desktop labels Aug 27, 2020

srirambv changed the title ~~Use GreaseLion for YouTube publishers~~ [Desktop] Use GreaseLion for YouTube publishers Sep 9, 2020

emerick closed this as completed in brave/brave-core#5440 Sep 14, 2020

NejcZdovc modified the milestones: 1.15.x - Beta, 1.16.x - Nightly Sep 14, 2020

LaurenWags mentioned this issue Sep 28, 2020

[Desktop] generic YT favicon displayed for verified creator in certain cases #11883

Closed

LaurenWags mentioned this issue Sep 28, 2020

[Desktop] sometimes the publisher name isn't shown on the panel only "on Youtube" is shown #11888

Closed

LaurenWags added the QA Pass-macOS label Sep 30, 2020

btlechowski added the QA Pass-Linux label Oct 13, 2020

GeetaSarvadnya added the QA Pass-Win64 label Oct 16, 2020

bsclifton changed the title ~~[Desktop] Use GreaseLion for YouTube publishers~~ [Desktop] Use Greaselion for YouTube publishers Oct 26, 2020

LaurenWags mentioned this issue Oct 26, 2020

Release Notes for 1.16.x Release #1 (Release Channel) #12317

Closed

rebron changed the title ~~[Desktop] Use Greaselion for YouTube publishers~~ Use Greaselion for YouTube publishers Oct 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Greaselion for YouTube publishers #9133

Use Greaselion for YouTube publishers #9133

NejcZdovc commented Apr 10, 2020 •

edited

Loading

LaurenWags commented Sep 28, 2020 •

edited by GeetaSarvadnya

Loading

Use Greaselion for YouTube publishers #9133

Use Greaselion for YouTube publishers #9133

Comments

NejcZdovc commented Apr 10, 2020 • edited Loading

LaurenWags commented Sep 28, 2020 • edited by GeetaSarvadnya Loading

NejcZdovc commented Apr 10, 2020 •

edited

Loading

LaurenWags commented Sep 28, 2020 •

edited by GeetaSarvadnya

Loading