Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BAT Tips on Github's People page is causing a layout issue #9024

Closed
Nuc1eoN opened this issue Apr 4, 2020 · 1 comment · Fixed by brave/brave-core#5215
Closed

BAT Tips on Github's People page is causing a layout issue #9024

Nuc1eoN opened this issue Apr 4, 2020 · 1 comment · Fixed by brave/brave-core#5215
Assignees
@NejcZdovc
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.9.x - Release

Comments

@Nuc1eoN
Copy link

Nuc1eoN commented Apr 4, 2020 •
edited by rebron
Loading

brave_gihub_bug

At the bottom right you see how the BATs "tip" feature messes up the rows.

Brave v1.5.122

Description

edit. @rebron
Remove the BAT Tips logo/insertion on an org's Github People page as it's causing a layout issue in the rows section and users won't likely tip from here.
@NejcZdovc NejcZdovc self-assigned this Apr 10, 2020
@NejcZdovc NejcZdovc added this to the 1.9.x - Nightly milestone Apr 10, 2020
@NejcZdovc NejcZdovc mentioned this issue Apr 10, 2020
Merged
32 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 10, 2020
@NejcZdovc
Fixes org pages for github
7b0a8cb 
Resolves brave/brave-browser#9024
@LaurenWags
Copy link
Member

LaurenWags commented May 1, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave | 1.9.51 Chromium: 81.0.4044.129 (Official Build) beta (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | macOS Version 10.14.6 (Build 18G3020)

Using 1.8.86, confirmed BAT tip logo visible on org's people page
Screen Shot 2020-05-01 at 8 27 07 AM

Verified using 1.9.x that org's people page does not contain BAT logo:
Screen Shot 2020-05-01 at 8 29 52 AM

Verification passed on

Brave | 1.9.52 Chromium: 81.0.4044.129 (Official Build) dev (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified 1.8.86, confirmed BAT tip logo visible on org's people page
  • Verified using 1.9.x that org's people page does not contain BAT logo:
    image

Verification passed on

Brave 1.9.55 Chromium: 81.0.4044.129 (Official Build) dev (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS Ubuntu 18.04 LTS

@rebron rebron changed the title BAT "tip" integration messes up Github's 'People' page BAT Tips on Github's People page is causing a layout issue May 20, 2020
@LaurenWags LaurenWags mentioned this issue May 20, 2020
Closed
@emerick emerick mentioned this issue Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.9.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes org pages for github brave/brave-core
5 participants
@Nuc1eoN @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya