Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto-increment from contribution_queue #8804

Closed
NejcZdovc opened this issue Mar 22, 2020 · 1 comment · Fixed by brave/brave-core#5642
Closed

Remove auto-increment from contribution_queue #8804

NejcZdovc opened this issue Mar 22, 2020 · 1 comment · Fixed by brave/brave-core#5642

Comments

@NejcZdovc
Copy link
Contributor

Currently we have auto increment on contribution_queue. This complicates things now that we moved DB into shared lib. To simplify this we should switch from INT AUTOINCREMENT to string uuid. This way we generate it ahead of time and publishers for the queue can be inserted without any problems.

@LaurenWags
Copy link
Member

LaurenWags commented Jun 16, 2020

Verified passed with

Brave 1.11.65 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-06-16 at 12 10 47 PM

  • Confirmed tipping via various methods was processed and displayed in UI as expected:

Scenario 1 - tipping using VG (UGP grant)
8804 - scenario 1 - tip with VG - 1
8804 - scenario 1 - tip with VG - 2
8804 - scenario 1 - tip with VG - 3

Scenario 2 - tipping with restored wallet (anon user funds)
8804 - scenario 2 - tip with restored wallet - 1
8804 - scenario 2 - tip with restored wallet - 2
8804 - scenario 2 - tip with restored wallet - 3

Scenario 3 - tipping with KYC'd Uphold wallet
8804 - scenario 3 - tip with Uphold - 1
8804 - scenario 3 - tip with Uphold - 2
8804 - scenario 3 - tip with Uphold - 3

Verification passed on


Brave | 1.11.68 Chromium: 83.0.4103.106 (Official Build) dev (64-bit)
-- | --
Revision | ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS | Windows 10 OS Version 1903 (Build 18362.30)

One time tip using UGP grants:
image
image
image

Tipping with restored wallet
image
image
image

Tipping with KYC'd account
image
image
image


Verified passed with

Brave	1.11.84 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Linux

Screen Shot 2020-07-01 at 12 01 37 PM

  • Confirmed tip was processed and displayed in UI as expected:

Screen Shot 2020-07-01 at 12 02 16 PM

Screen Shot 2020-07-01 at 12 02 26 PM

Screen Shot 2020-07-01 at 12 02 38 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment