Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Settings page has a small grey square in the top right of the vertical scrollbar #8365

Closed
phoogm opened this issue Feb 22, 2020 · 6 comments · Fixed by brave/brave-core#5679
Labels
feature/global-settings Settings at browser level independent of shields settings OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@phoogm
Copy link

phoogm commented Feb 22, 2020

Test plan

See brave/brave-core#5842

Description

For Brave 1.3.118 on the settings page a grey square is displayed top right underneath the menu bar.

Steps to Reproduce

  1. Using Brave desktop browser 1.3.118 for Mac, open the settings page
  2. Check the spot underneath the menu bar top right site, a grey square is displayed
  3. When the settings are show the grey square will appear on top of the scrollbar, when the about Brave panel is displayed the grey square is also displayed.

Actual result:

settings grey block

Expected result:

Grey Square should be removed from settings page layout.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 1.3.118 Chromium: 80.0.3987.116 (Official Build) (64-bit)
Revision | dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS | macOS Version 10.15.3 (Build 19D76)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes - 1.3.118
  • Can you reproduce this issue with the beta channel? Yes - 1.5.96
  • Can you reproduce this issue with the dev channel? Yes - 1.6.47
  • Can you reproduce this issue with the nightly channel? Yes - 1.7.7

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Checked Brave 1.3.118 on Windows 10 and Brave 1.3.118 on Ubuntu and they have the same issue.

@rebron rebron added feature/global-settings Settings at browser level independent of shields settings priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Apr 17, 2020
@rebron
Copy link
Collaborator

rebron commented Apr 17, 2020

cc: @petemill One of those once you see it, can't unsee it bugs.

@bsclifton
Copy link
Member

Talked with @petemill and showed the bug - this should be in br_toolbar component. I can check this out 😄

@bsclifton
Copy link
Member

Fixed with Chromium 84 🎉

@btlechowski
Copy link

Marking as QA/Blocked - need a new build to test, 1.11.92 or newer.

@LaurenWags
Copy link
Member

Removing QA/Blocked, build https://github.com/brave/brave-browser/releases/tag/v1.11.92 is available

@LaurenWags
Copy link
Member

LaurenWags commented Jul 8, 2020

Verified passed with

Brave | 1.11.92 Chromium: 84.0.4147.68 (Official Build) dev (64-bit)
-- | --
Revision | e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-07-08 at 8 18 37 AM

Screen Shot 2020-07-08 at 8 23 52 AM

  • Confirmed brave://downloads still has ellipsis menu and it can be clicked on. Confirmed single option on menu worked as expected.

Screen Shot 2020-07-08 at 8 19 07 AM

Screen Shot 2020-07-08 at 8 19 15 AM

  • Confirmed brave://bookmarks still has ellipsis menu and it can be clicked on. Confirmed each option on menu worked as expected.

Screen Shot 2020-07-08 at 8 19 55 AM

Screen Shot 2020-07-08 at 8 20 05 AM


Verification passed on

Brave | 1.11.92 Chromium: 84.0.4147.68 (Official Build) dev (64-bit)
-- | --
Revision | e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS | Windows 10 OS Version 1903 (Build 18362.900)

  • Confirmed brave://downloads still has ellipsis menu and it can be clicked on. Confirmed single option on menu worked as expected.
    image
    image
  • Confirmed brave://bookmarks still has ellipsis menu and it can be clicked on. Confirmed each option on menu worked as expected.
    image
    image
    image

Verification passed on

Brave 1.11.92 Chromium: 84.0.4147.68 (Official Build) dev (64-bit)
Revision e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS Ubuntu 18.04 LTS
  • Verified test plan from Update check used for slot filled check on br_toolbar brave-core#5842

  • Confirmed no square in top right corner of scroll bar, checked for both light and dark themes:
    image
    image

  • Confirmed brave://downloads still has ellipsis menu and it can be clicked on. Confirmed single option on menu worked as expected.
    image
    image

  • Confirmed brave://bookmarks still has ellipsis menu and it can be clicked on. Confirmed each option on menu worked as expected.
    image
    image

@rebron rebron changed the title Settings Page Grey Square top right corner [Desktop] Settings page has a small grey square in the top right of the vertical scrollbar Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
7 participants