Twitter tipping success/share tweet: Twitter handle displays as a string of numbers in tweet.

[lukemulks]

Description

I was going through the process of tweeting that I had tipped a Twitter creator, and noticed that instead of the twitter handle for the creator displaying the twitter handle as expected, instead the handle was populated by a string of numbers.

Screenshots below show the Twitter Creator w/the proper handle, and what the "I've just tipped" Tweet populated the handle with.

Steps to Reproduce

1. Tip someone on Twitter
2. Click the button in the rewards panel to tweet that you've tipped the creator
3. Observe the handle replaced with a string of numbers.

Actual result:

Expected result:

Should display the Twitter handle

Reproduces how often:

Have not attempted more than once at this point.

Brave version (brave://version info)

Brave	1.5.91 Chromium: 80.0.3987.100 (Official Build) dev (64-bit)
Revision	3f00c26d457663a424865bbef1179f72eec1b9fe-refs/branch-heads/3987@{#864}

Version/Channel Information:

• Can you reproduce this issue with the current release? TBD
• Can you reproduce this issue with the beta channel? TBD
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? TBD

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[bsclifton]

cc: @NejcZdovc @jsecretan @tmancey

[rebron]

cc: @emerick

[rebron]

Looks like this only effecting certain publishers. Tested on Khan Academy and chess.com and it looks like it's working properly there.

[emerick]

That's weird, it grabbed the Tweet ID and used that instead of the name. We made several changes to the Twitter implementation recently in nightly. None were explicitly to address this, but it would make sense to retest first to make sure this is still happening. I tried tipping a few tweets to this user just now and wasn't able to repro FWIW.

[jonathansampson]

I believe @w0ts0n just ran into this too.

[LaurenWags]

Verified passed with

Brave | 1.17.45 Chromium: 86.0.4240.99 (Official Build) dev (x86_64)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified STR from description both when tipping via in-line tip button and tipping from the panel.

Tipped a verified and non-verified twitter publisher (using staging env). Confirmed canned tweet showed publisher name as expected.

Screenshots

Original publisher from description (not verified on staging env) - twitter.com/queentatiana:

Verified on staging publisher - twitter.com/emerick:

---

Verification passed on

Brave | 1.17.52 Chromium: 86.0.4240.111 (Official Build) dev (64-bit)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | Windows 10 OS Version 1903 (Build 18362.1139)

Verified STR from description both when tipping via in-line tip button and tipping from the panel.

Tipped a verified and non-verified twitter publisher (using staging env). Confirmed canned tweet showed publisher name as expected.

Screenshots

Tip from BR panel - twitter.com/brave (non verified pub in staging env)

Inline tip - twitter.com/brave (staging env)

Tip from BR panel - https://twitter.com/queentatiana (staging env)

Inline tip - https://twitter.com/queentatiana (staging env)

Tip from BR panel - https://twitter.com/bravelaurenwags (verified pub in staging env)

Inline tip from BR panel - https://twitter.com/bravelaurenwags (verified pub in staging env)

[jonathansampson]

This happened to me just now in v1.21.65 (presently Brave Beta):

From https://twitter.com/kentcdodds/status/1364736650555756544, I scrolled down to the following and clicked Tip:

The tipping banner did not show any issue with displaying the publisher's username: