[Desktop] Immediate crash after upgrading to 1.5.90

[darkdh]

Description

Launch upgrade on dev channel and immediately crash after relaunch

Steps to Reproduce

1. Upgrade to 1.5.90
2. Crash immediately after relaunch

Actual result:

Crash https://stats.brave.com/dashboard#crash/5e45dbffbf3283006a749dc2

 0  Brave Browser Dev Framework! [values.cc : 290 + 0x0]
    rax = 0x00000001074752d0   rdx = 0x0000000101282e08
    rcx = 0x00000001074752e0   rbx = 0x00007fe69802afd0
    rsi = 0x00007fe69802afd0   rdi = 0x000070000cf17298
    rbp = 0x000070000cf171e0   rsp = 0x000070000cf171a0
     r8 = 0x0000000000000000    r9 = 0x0000000001100044
    r10 = 0x0000000000000003   r11 = 0x00007fe60d623cf0
    r12 = 0x00007fe69802aec0   r13 = 0x000070000cf172b8
    r14 = 0x000070000cf17298   r15 = 0x0000000000000000
    rip = 0x00000001074752d1
    Found by: given as instruction pointer in context
 1  Brave Browser Dev Framework!content_settings::(anonymous namespace)::CloneRule(content_settings::Rule const&, bool) [brave_content_settings_pref_provider.cc : 42 + 0x8]
    rbp = 0x000070000cf17370   rsp = 0x000070000cf171f0
    rip = 0x0000000105a6a6fb
    Found by: previous frame's frame pointer
 2  Brave Browser Dev Framework!content_settings::(anonymous namespace)::BraveShieldsRuleIterator::Next() [brave_content_settings_pref_provider.cc : 57 + 0xa]
    rbp = 0x000070000cf17390   rsp = 0x000070000cf17380
    rip = 0x0000000105a6aa52
    Found by: previous frame's frame pointer
 3  Brave Browser Dev Framework!HostContentSettingsMap::GetContentSettingValueAndPatterns(content_settings::RuleIterator*, GURL const&, GURL const&, ContentSettingsPattern*, ContentSettingsPattern*) [host_content_settings_map.cc : 969 + 0xc]
    rbp = 0x000070000cf17510   rsp = 0x000070000cf173a0
    rip = 0x0000000109b8b645
    Found by: previous frame's frame pointer
 4  Brave Browser Dev Framework!HostContentSettingsMap::GetContentSettingValueAndPatterns(content_settings::ProviderInterface const*, GURL const&, GURL const&, ContentSettingsType, std::__1::basic_string, std::__1::allocator > const&, bool, ContentSettingsPattern*, ContentSettingsPattern*) [host_content_settings_map.cc : 951 + 0x12]
    rbp = 0x000070000cf175a0   rsp = 0x000070000cf17520
    rip = 0x0000000109b8a731
    Found by: previous frame's frame pointer
 5  Brave Browser Dev Framework!HostContentSettingsMap::GetWebsiteSettingInternal(GURL const&, GURL const&, ContentSettingsType, std::__1::basic_string, std::__1::allocator > const&, HostContentSettingsMap::ProviderType, content_settings::SettingInfo*) const [host_content_settings_map.cc : 904 + 0x21]
    rbp = 0x000070000cf176c0   rsp = 0x000070000cf175b0
    rip = 0x0000000109b89788
    Found by: previous frame's frame pointer
 6  Brave Browser Dev Framework!HostContentSettingsMap::GetWebsiteSetting(GURL const&, GURL const&, ContentSettingsType, std::__1::basic_string, std::__1::allocator > const&, content_settings::SettingInfo*) const [host_content_settings_map.cc : 869 + 0x1e]
    rbp = 0x000070000cf177b0   rsp = 0x000070000cf176d0
    rip = 0x0000000109b895fd
    Found by: previous frame's frame pointer
 7  Brave Browser Dev Framework!content_settings::CookieSettings::GetCookieSettingInternal(GURL const&, GURL const&, bool, content_settings::SettingSource*, ContentSetting*) const [cookie_settings.cc : 184 + 0x1a]
    rbp = 0x000070000cf17940   rsp = 0x000070000cf177c0
    rip = 0x0000000109b87160
    Found by: previous frame's frame pointer
 8  Brave Browser Dev Framework!content_settings::CookieSettingsBase::IsCookieSessionOnly(GURL const&) const [cookie_settings_base.cc : 67 + 0x16]
    rbp = 0x000070000cf17970   rsp = 0x000070000cf17950
    rip = 0x00000001087a0161
    Found by: previous frame's frame pointer
 9  Brave Browser Dev Framework!storage::QuotaManager::GetUsageAndQuotaWithBreakdown(url::Origin const&, blink::mojom::StorageType, base::OnceCallback)>) [quota_manager.cc : 945 + 0xc]
    rbp = 0x000070000cf17a50   rsp = 0x000070000cf17980
    rip = 0x000000010978213f
    Found by: previous frame's frame pointer
10  Brave Browser Dev Framework!storage::QuotaManager::GetUsageAndQuotaForWebApps(url::Origin const&, blink::mojom::StorageType, base::OnceCallback) [quota_manager.cc : 922 + 0x17]
    rbp = 0x000070000cf17a90   rsp = 0x000070000cf17a60
    rip = 0x0000000109782003
    Found by: previous frame's frame pointer
11  Brave Browser Dev Framework!storage::QuotaManager::GetUsageAndQuota(url::Origin const&, blink::mojom::StorageType, base::OnceCallback) [quota_manager.cc : 963 + 0x16]
    rbp = 0x000070000cf17b50   rsp = 0x000070000cf17aa0
    rip = 0x00000001097823d9
    Found by: previous frame's frame pointer
12  Brave Browser Dev Framework!storage::QuotaManagerProxy::GetUsageAndQuota(base::SequencedTaskRunner*, url::Origin const&, blink::mojom::StorageType, base::OnceCallback) [quota_manager_proxy.cc : 136 + 0x17]
    rbp = 0x000070000cf17bd0   rsp = 0x000070000cf17b60
    rip = 0x000000010978bf94
    Found by: previous frame's frame pointer

Expected result:

No crash

Reproduces how often:

Brave version (brave://version info)

Version 1.5.90 Chromium: 80.0.3987.87 (Official Build) dev (64-bit)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the dev channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[darkdh]

 270 Value Value::Clone() const {
 271   switch (type_) {
 272     case Type::NONE:
 273       return Value();
 274     case Type::BOOLEAN:
 275       return Value(bool_value_);
 276     case Type::INTEGER:
 277       return Value(int_value_);
 278     case Type::DOUBLE:
 279       return Value(AsDoubleInternal());
 280     case Type::STRING:
 281       return Value(string_value_);
 282     case Type::BINARY:
 283       return Value(binary_value_);
 284     case Type::DICTIONARY:
 285       return Value(dict_);
 286     case Type::LIST:
 287       return Value(list_);
 288       // TODO(crbug.com/859477): Remove after root cause is found.
 289     case Type::DEAD:
>>> 290       CHECK(false);

[darkdh]

closed by brave/brave-core#4653