Tor window option shows on macOS File menu when Tor is off in settings

[LaurenWags]

Description

Found while testing #6808

If Tor is toggled off in brave://settings/extensions, the New Private Window with Tor option is removed from hamburger menu on Normal, Private, and Guest windows. However, it still displays in the macOS File menu but it is grayed out.

Steps to Reproduce

1. Navigate to brave://settings/extensions
2. Toggle Tor off
3. Click on File menu (on macOS)

Actual result:

New Private Window with Tor option is still visible (grayed out)

Expected result:

Since it was removed from hamburger menu I expected it to be removed from File menu also.

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.4.85 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision	449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS	macOS Version 10.14.6 (Build 18G103)

Version/Channel Information:

• Can you reproduce this issue with the current release? n/a
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the dev channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @kjozwiak @simonhong

[simonhong]

@LaurenWags This is expected behavior. File menu will be updated after re-starting.
Hamburger menu is newly constructed whenever browser window is created.
However, file menu is only constructed when browser launches.

[LaurenWags]

@simonhong I'm actually still seeing it after restart. Are you able to reproduce? I'm using

Brave	1.4.85 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision	449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS	macOS Version 10.14.6 (Build 18G103)

[simonhong]

@LaurenWags Oh, you're right! I assumed it would work like app menu.