Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to #8031 - Missing string on NTP SI widget #8126

Closed
btlechowski opened this issue Feb 7, 2020 · 2 comments
Closed

Follow up to #8031 - Missing string on NTP SI widget #8126

btlechowski opened this issue Feb 7, 2020 · 2 comments

Comments

@btlechowski
Copy link

btlechowski commented Feb 7, 2020

Follow up to #8031 - Turn on Brave Ads to claim your share. You can also choose to hide sponsored images is not translated into Polish

Steps to Reproduce

  1. Clean install in Polish
  2. Enable Rewards
  3. Disable Ads
  4. Enable NTP SI Demo flag
  5. Open NTP SI

Actual result:

Missing string on NTP SI widget for Polish language
image

Expected result:

Turn on Brave Ads to claim your share. You can also choose to hide sponsored images is translated into Polish

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.3.113 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @mkarolin @rebron @bsclifton @NejcZdovc @petemill

@rebron rebron changed the title Follow up to #8031 - Missing string on NTP SI widget for Polish language Follow up to #8031 - Missing string on NTP SI widget Feb 11, 2020
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 3, 2020
@rebron rebron self-assigned this Apr 3, 2020
@rebron
Copy link
Collaborator

rebron commented Apr 28, 2020

@btlechowski Can you recheck in 1.8.x when you get a chance?

@btlechowski
Copy link
Author

btlechowski commented May 28, 2020

No longer reproducible

Verification passed on

Brave 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image

Verification passed on

Brave | 1.10.77 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

  • Verified test plan from the description
    image

Verified passed with

Brave | 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Wersja 10.14.6 (kompilacja 18G3020)
  • Verified STR from description

Zrzut ekranu 2020-06-1 o 11 06 41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants