Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #8044 - C80 - unable to open PDF in PT and TOR tabs #8090

Closed
GeetaSarvadnya opened this issue Feb 6, 2020 · 3 comments · Fixed by brave/brave-core#4534
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 6, 2020

Description

Follow up of #8044 - C80 - unable to open PDF in PT and TOR tabs

Steps to Reproduce

  1. Clean profile 1.3.111-Chromium: 80.0.3987.85
  2. Open a PT and TOR tab
  3. Open a PDF file in PT or TOR tab (https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf)
  4. Unable to open PDF files in PT and TOR tabs

Actual result:

Unable to open PDF files in PT and TOR tabs
image

Expected result:

PDF files should open in PT and TOR tabs

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.3.111 Chromium: 80.0.3987.85 (Official Build) (64-bit)
Revision 583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Not sure
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @bsclifton @yrliou

@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2020

Reproducible on macOS 10.15.3 x64 using the following build:

Brave 1.6.5 Chromium: 80.0.3987.85 (Official Build) nightly (64-bit)
Revision 583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS macOS Version 10.15.3 (Build 19D76)

Nice catch @GeetaSarvadnya 👍

@rebron
Copy link
Collaborator

rebron commented Feb 7, 2020

screen_shot_2020-02-07_at_12 32 36_am

Looks good, on macOS, Windows both private window and private window with Tor
Brave 1.3.113 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.3 (Build 19D76)

Verification passed on

Brave 1.3.113 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

Verified test plan from the description. Verified for http, https and dynamically generated pdf

Private Window
image

Private Window with Tor
image

Regular Window
image

Guest Window
image

Multi profile
image

@kjozwiak
Copy link
Member

kjozwiak commented Feb 7, 2020

Awesome, thanks @rebron 👍 Labeling as passed on macOS & Win x64 as per the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment