Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal issue 679 (referrer) #7933

Closed
fmarier opened this issue Jan 27, 2020 · 1 comment · Fixed by brave/brave-core#6674
Closed

Internal issue 679 (referrer) #7933

fmarier opened this issue Jan 27, 2020 · 1 comment · Fixed by brave/brave-core#6674
Assignees
@iefremov
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.18.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Jan 27, 2020

https://github.com/brave/internal/issues/679
@tildelowengrimm tildelowengrimm added priority/P3 The next thing for us to work on. It'll ride the trains. privacy priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 28, 2020
@fmarier fmarier self-assigned this Feb 12, 2020
@pes10k pes10k mentioned this issue May 12, 2020
Closed
@fmarier fmarier mentioned this issue May 27, 2020
Merged
32 tasks
@iefremov iefremov self-assigned this May 27, 2020
@fmarier fmarier removed their assignment Jun 15, 2020
@fmarier fmarier assigned fmarier and unassigned iefremov Sep 18, 2020
fmarier added a commit to fmarier/brave-core that referenced this issue Sep 19, 2020
@fmarier
WIP: Fix referrer handling of redirected navigations (fixes brave/bra…
aae6562 
…ve-browser#7933)

This appears to be in the wrong hook. It's not clear it's even
needed.
@iefremov iefremov mentioned this issue Sep 21, 2020
Merged
32 tasks
@iefremov iefremov self-assigned this Sep 21, 2020
@fmarier fmarier removed their assignment Sep 22, 2020
@iefremov iefremov added this to the 1.18.x - Nightly milestone Oct 23, 2020
@iefremov iefremov added OS/Android Fixes related to Android browser functionality OS/Desktop release-notes/exclude labels Oct 23, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Dec 1, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave | 1.18.66 Chromium: 87.0.4280.67 (Official Build) dev (x86_64)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | macOS Version 10.15.7 (Build 19H15)

Verified test plan from https://github.com/brave/internal/issues/679#issuecomment-715298477

Verification passed on LG Nexus 5 with Android 5.1 running 1.18.67 Bravearm.apk

Verification passed on


Brave | 1.18.68 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Windows 10 OS Version 2004 (Build 19041.630)

Verified test plan from https://github.com/brave/internal/issues/679#issuecomment-715298477

Verification passed on

Brave 1.18.70 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/internal/issues/679#issuecomment-715298477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iefremov iefremov

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging a pull request may close this issue.

Fix referrer protections for frame redirects. brave/brave-core
6 participants
@fmarier @tildelowengrimm @iefremov @LaurenWags @btlechowski @GeetaSarvadnya