Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab Bar shadows #788

Closed
petemill opened this issue Aug 20, 2018 · 2 comments
Closed

Tab Bar shadows #788

petemill opened this issue Aug 20, 2018 · 2 comments
Assignees
@petemill
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design A design change, especially one which needs input from the design team

Comments

@petemill
Copy link
Member

Tab Bar inset / Active Tab outset shadows

image
@petemill petemill added the design A design change, especially one which needs input from the design team label Aug 20, 2018
@petemill petemill added this to the 1.0 milestone Aug 20, 2018
@petemill petemill mentioned this issue Sep 27, 2018
Closed
14 tasks
petemill added a commit to brave/brave-core that referenced this issue Sep 27, 2018
@petemill
Add shadows to tabs
ab58135 
Adds tab painting function for shadows.

In order to paint the tab's (top) shadow above the tab's (previous) bounds rectangle, we must extend the tab (and tabstrip) higher, to the top of the window (usually 8px of space). This is because the Views framework does not allow painting outside a View's bounds.

A hacky alternative would be to pass the PaintInfo from the BrowserView through the TabStrip child to the Tab descendants, so that a canvas can be created that can span the larger window rectangle. Aside from that strategy not done anywhere else in Chromium, it could cause issues if the tabs end up on a different paint layer, as well as paint invalidation and caching issues that would need to be solved.

Close brave/brave-browser#788
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 8, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@petemill petemill self-assigned this May 22, 2019
@btlechowski btlechowski mentioned this issue Dec 3, 2019
Closed
This was referenced Dec 3, 2019
Closed
Closed
Closed
This was referenced Dec 3, 2019
Closed
Closed
Closed
@btlechowski btlechowski mentioned this issue Dec 10, 2019
Closed
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Feb 5, 2020
@karenkliu karenkliu mentioned this issue Aug 31, 2020
Closed
@karenkliu
Copy link

@rebron Should we close this as won't fix for now?

This was referenced Feb 24, 2022
Closed
Closed
@MadhaviSeelam MadhaviSeelam mentioned this issue Feb 25, 2022
Closed
@btlechowski btlechowski mentioned this issue Feb 25, 2022
Closed
@stephendonner stephendonner mentioned this issue Feb 25, 2022
Closed
This was referenced Feb 25, 2022
Closed
Closed
Closed
This was referenced Feb 25, 2022
Closed
Closed
This was referenced Feb 25, 2022
Closed
Closed
This was referenced Feb 26, 2022
Closed
Closed
@btlechowski btlechowski mentioned this issue Feb 28, 2022
Closed
@stephendonner stephendonner mentioned this issue Feb 28, 2022
Closed
@btlechowski btlechowski mentioned this issue Feb 28, 2022
Closed
@stephendonner stephendonner mentioned this issue Mar 1, 2022
Open
@rebron
Copy link
Collaborator

rebron commented Mar 22, 2022

Closing as stale.

@rebron rebron closed this as completed Mar 22, 2022
@rebron rebron added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Mar 22, 2022
@rebron rebron removed the priority/P4 Planned work. We expect to get to it "soon". label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. design A design change, especially one which needs input from the design team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Add shadows to tabs brave/brave-core
4 participants
@petemill @bbondy @karenkliu @rebron