Disable opening Tor in guest window

[yrliou]

Description

Currently UI items for opening private window in a guest window is disabled, we should behave the same to not allow opening Tor window in a guest window too to be consistent.

Steps to Reproduce

1. Open a guest window and visit brave.com
2. Open hamburger menu, file menu (macOS)
3. Open context menu by right click on a link in the website.

Actual result:

Hamburger menu:

File menu (macOS):

Context menu:

Expected result:

Hamburger menu:

File menu (macOS):

Context menu:

Reproduces how often:

Always.

Brave version (brave://version info)

For all versions after 1.1.x.

[LaurenWags]

@yrliou looks like the option for New Private Window with Tor is still displayed in the hamburger menu but is grayed out. Test plan in PR specifies that this shouldn't be there though. Can you confirm if what we should be seeing? Since this option is grayed out from macOS file menu and on context menu I'd guess grayed out in hamburger menu is ok as well, but would like to confirm. Thanks!

Brave	1.2.27 Chromium: 79.0.3945.79 (Official Build) beta (64-bit)
Revision	29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS	macOS Version 10.13.6 (Build 17G5019)

[bsclifton]

@LaurenWags this behavior should be good 😄 I believe this is properly fixed in 1.4 with brave/brave-core#4235 (see screenshots)

[yrliou]

@LaurenWags There are something that my PR was built upon which is only in 1.3 and later. I only uplift my own PR to make changes minimum, we should be fine in later versions.

[LaurenWags]

thanks for confirming @bsclifton and @yrliou 😄

[btlechowski]

Verification passed on

Brave	1.2.28 Chromium: 79.0.3945.79 (Official Build) beta (64-bit)
Revision	29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4155
Encountered #7237 (comment)

Verified passed with

Brave	1.2.27 Chromium: 79.0.3945.79 (Official Build) beta (64-bit)
Revision	29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified test plan from Disable opening Tor options in guest window brave-core#4155

Verification passed on

Brave	1.2.36 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision	c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from Disable opening Tor options in guest window brave-core#4155
• Encountered Disable opening Tor in guest window #7237 (comment)