Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor WalletProperties #7165

Closed
NejcZdovc opened this issue Dec 2, 2019 · 2 comments · Fixed by brave/brave-core#5647
Closed

Refactor WalletProperties #7165

NejcZdovc opened this issue Dec 2, 2019 · 2 comments · Fixed by brave/brave-core#5647
Assignees
@NejcZdovc
Labels
dev-concern feature/rewards QA/No release-notes/exclude
Milestone
1.11.x - Release #1

Comments

@NejcZdovc
Copy link
Contributor

Before Virtual Grants we had balance, grants, etc in WalletProperties so name made sense. Now that grants and balance are decoupled this name doesn't make any sense. We should rename it to something like ServerProperties, because we will be getting default values and other general info from the server that we can then use in the UI.

Second thing that we should do is remove observer OnWalletProperties (just use callback). It doesn't make any sense to have is as we should only return value to the caller.
@NejcZdovc NejcZdovc added feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. dev-concern labels Dec 2, 2019
@NejcZdovc
Copy link
Contributor Author

maybe should be done as part of this effort #8428

@NejcZdovc
Copy link
Contributor Author

should be done when #9132 is done

@NejcZdovc NejcZdovc removed the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Apr 10, 2020
@NejcZdovc NejcZdovc mentioned this issue May 26, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc self-assigned this May 26, 2020
@NejcZdovc NejcZdovc added this to the 1.11.x - Nightly milestone Jun 2, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 2, 2020
@NejcZdovc
Transition WalletProperties to Parameters
4fc7c73 
brave/brave-browser#7165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
dev-concern feature/rewards QA/No release-notes/exclude
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging a pull request may close this issue.

Move data from ledger_state into preferences brave/brave-core
1 participant
@NejcZdovc