Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to #5722 - Wrong ads server url for ads/confirmations development environment #7132

Closed
btlechowski opened this issue Nov 27, 2019 · 1 comment · Fixed by brave/brave-core#4108

Comments

@btlechowski
Copy link

Follow up to #5722. The url used for ads development environment is wrong.

Steps to Reproduce

  1. Run Brave with flags --enable-logging=stderr --vmodule=brave_ads=3 --brave-ads-development --rewards=development=true
  2. Enable rewards
  3. Check logs

Actual result:

ads urls points to ads-serve.brave.software.com server
ads grant is shown by default
image
Was unable to claim the grant
image
ads catalog was not downloaded, because it points to dummy https://ads-serve.brave.software.com/v1/catalog

Expected result:

ads urls points to ads-serve.brave.software server
rewards and ads work as expected

Note: expected ads url was provided by @tmancey

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.2.11 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @tmancey

@tmancey tmancey changed the title Follow up to #5722 - Wrong ads server url for ads development environment Follow up to #5722 - Wrong ads server url for ads/confirmations development environment Nov 29, 2019
@tmancey tmancey added the bug label Nov 29, 2019
@tmancey tmancey self-assigned this Nov 29, 2019
@tmancey tmancey added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 29, 2019
@tmancey tmancey added this to the 1.3.x - Nightly milestone Nov 30, 2019
@btlechowski
Copy link
Author

btlechowski commented Jan 9, 2020

Verification passed on

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS

Verified test plan from the description. The domain used is ads-serve.brave.software, which is actual domain.

image

Verification passed on

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from the description. The domain used is ads-serve.brave.software, which is the actual domain.
    image

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.2 (Build 19C57)
[47724:775:0114/232459.927979:INFO:confirmations_impl.cc(778)] SetWalletInfo:
[47724:775:0114/232459.928003:INFO:confirmations_impl.cc(779)]   Payment id: da7642f4-1d2e-47a4-8d21-0a79a4d74188
[47724:775:0114/232459.928012:INFO:confirmations_impl.cc(780)]   Private key: ********
[47724:775:0114/232459.928042:INFO:confirmations_impl.cc(690)] Saving confirmations state
[47724:775:0114/232459.928079:INFO:ads_rewards.cc(54)] Fetch ads rewards
[47724:775:0114/232459.928089:INFO:ads_rewards.cc(114)] GetPaymentBalance
[47724:775:0114/232459.928096:INFO:ads_rewards.cc(116)] GET /v1/confirmation/payment/{payment_id}
[47724:775:0114/232459.928104:INFO:ads_rewards.cc(119)] URL Request:
[47724:775:0114/232459.928112:INFO:ads_rewards.cc(122)]   URL: https://ads-serve.brave.software/v1/confirmation/payment/da7642f4-1d2e-47a4-8d21-0a79a4d74188
[47724:775:0114/232459.928120:INFO:ads_rewards.cc(127)]   Body: {}
[47724:775:0114/232459.929300:INFO:ads_rewards.cc(130)]   Headers:
[47724:775:0114/232459.929310:INFO:ads_rewards.cc(132)]     digest: SHA-256=RBNvo1WzZ4oRRq0W9+hknpT7T8If536DEMBg9hyq/4o=
[47724:775:0114/232459.929318:INFO:ads_rewards.cc(132)]     signature: keyId="primary",algorithm="ed25519",headers="digest",signature="n+0W2ln3IoZBldkbe+0TJGkqhi4as6Yx+d0ZMduk0fwvasFAmmIKPoWb4H2cfb83u6BdFELbsrhyD8nZsOM6Cg=="
[47724:775:0114/232459.929325:INFO:ads_rewards.cc(132)]     accept: application/json
[47724:775:0114/232459.929332:INFO:ads_rewards.cc(136)]   Content_type: application/json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment