Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate widevine all prefs from profile to local_state #6747

Closed
simonhong opened this issue Nov 4, 2019 · 2 comments · Fixed by brave/brave-core#3959 or #6996
Closed

Migrate widevine all prefs from profile to local_state #6747

simonhong opened this issue Nov 4, 2019 · 2 comments · Fixed by brave/brave-core#3959 or #6996

Comments

@simonhong
Copy link
Member

After widevine cdm is installed, any user(profile) can use cdm library.
so, it doesn't make sense to ask again whenever new profile is created.

Reproduce step:

  1. Launch browser with clean profile
  2. Install widevine cdm (via https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://storage.googleapis.com/shaka-demo-assets/sintel-widevine/dash.mpd;panel=HOME;build=uncompiled)
  3. Create new profile
  4. Load again(https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://storage.googleapis.com/shaka-demo-assets/sintel-widevine/dash.mpd;panel=HOME;build=uncompiled)
  5. Check widevine prompt is displayed again

Result: prompt is displayed again. (Regardless of allow/deny, user can play contents)
Expected: prompt should not be displayed.

@simonhong simonhong added this to the 0.73.x - Nightly milestone Nov 4, 2019
@simonhong simonhong self-assigned this Nov 4, 2019
@simonhong simonhong changed the title Migrate kWidevineOptedIn prefs to local_state Migrate kWidevineOptedIn pref from profile to local_state Nov 4, 2019
@simonhong
Copy link
Member Author

simonhong commented Nov 7, 2019

kWidevineOptedIn, kAskWidevineInstall and kWidevineInstalledVersion

@btlechowski
Copy link

btlechowski commented Jan 9, 2020

Verification passed on

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS

Verified test plan from the description. The widevine prompt is not shown again.

Verification passed on

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from the description

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.2 (Build 19C57)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment