Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tab page top sites need to have an opaque, white background #6642

Closed
karenkliu opened this issue Oct 28, 2019 · 2 comments · Fixed by brave/brave-core#4424
Closed

New tab page top sites need to have an opaque, white background #6642

karenkliu opened this issue Oct 28, 2019 · 2 comments · Fixed by brave/brave-core#4424
Assignees
@cezaraugusto
Labels
accessibility bug feature/new-tab priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.5.x - Release

Comments

@karenkliu
Copy link

karenkliu commented Oct 28, 2019 •
edited by bsclifton
Loading

Test plan

New tab page topSites should have a white, opaque background (see proposed screenshot under Designs).

Description

Currently, the background for the top sites tiles are translucent:

Screen Shot 2019-10-28 at 2 56 09 PM

Screenshot taken from Version 0.73.26 Chromium: 78.0.3904.70 (Official Build) nightly (64-bit), but the issue is across all channels.

Top sites tiles need to be updated with opaque white backgrounds to improve contrast.

Designs

desktop sccreenshot dark-min
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Nov 22, 2019
@rebron rebron assigned cezaraugusto and unassigned rebron Dec 3, 2019
@karenkliu
Copy link
Author

bump ☝️

@cezaraugusto cezaraugusto mentioned this issue Jan 6, 2020
Closed
@cezaraugusto cezaraugusto mentioned this issue Jan 24, 2020
Merged
32 tasks
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 24, 2020
@cezaraugusto
NTP: Use solid color for topSites tiles background
84ff01f 
Fix brave/brave-browser#6642
@bsclifton bsclifton added this to the 1.5.x - Nightly milestone Jan 24, 2020
@btlechowski
Copy link

btlechowski commented Feb 28, 2020 •
edited by LaurenWags
Loading

Verification passed on

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Ubuntu 18.04 LTS

Reproduced on 1.4.95
image

Verified the test plan from the description
image

Verification passed on

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Reproduced on 1.4.89
image

Verified the test plan from the description
image

Verified passed with

Brave 1.5.105 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.14.6 (Build 18G3020)

Reproduced issue on 1.4.95:
Screen Shot 2020-03-02 at 11 58 54 AM

Verified fixed with 1.5.x:
Screen Shot 2020-03-02 at 12 00 01 PM

@kjozwiak kjozwiak mentioned this issue Mar 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
accessibility bug feature/new-tab priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.5.x - Release
Development

Successfully merging a pull request may close this issue.

NTP: Use solid color for topSites tiles background brave/brave-core
7 participants
@karenkliu @cezaraugusto @bsclifton @rebron @LaurenWags @btlechowski @GeetaSarvadnya